Many thanks Kowshik Jois for the successful verification. The verification results are at the duplicate bug: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2075721/comments/7 re-posting here:
------- Comment From kowshik.j...@in.ibm.com 2024-08-09 11:36 EDT------- I have tested this scenario with the noble-proposed kernel. I could attach and detach interfaces successfully. No crash/trace messages found. Guest Env: =========== Linux ubuntu 6.8.0-43-generic #43-Ubuntu SMP Fri Aug 2 19:46:18 UTC 2024 ppc64le ppc64le ppc64le GNU/Linux root@ubuntu:~# cat /boot/config-6.8.0-43-generic | grep PCI_DYNAMIC # CONFIG_PCI_DYNAMIC_OF_NODES is not set Before Attaching the Interface: ================================= root@ubuntu:~# ip addr 1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000 link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 inet 127.0.0.1/8 scope host lo valid_lft forever preferred_lft forever inet6 ::1/128 scope host noprefixroute valid_lft forever preferred_lft forever 2: enp0s1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000 link/ether 52:54:00:24:e5:58 brd ff:ff:ff:ff:ff:ff inet 192.168.122.187/24 metric 100 brd 192.168.122.255 scope global dynamic enp0s1 valid_lft 2749sec preferred_lft 2749sec inet6 fe80::5054:ff:fe24:e558/64 scope link valid_lft forever preferred_lft forever After Attaching the Interface: ================================= # virsh attach-interface Ubuntu2404 bridge --source virbr0 Interface attached successfully root@ubuntu:~# ip addr 1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000 link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 inet 127.0.0.1/8 scope host lo valid_lft forever preferred_lft forever inet6 ::1/128 scope host noprefixroute valid_lft forever preferred_lft forever 2: enp0s1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000 link/ether 52:54:00:24:e5:58 brd ff:ff:ff:ff:ff:ff inet 192.168.122.187/24 metric 100 brd 192.168.122.255 scope global dynamic enp0s1 valid_lft 2738sec preferred_lft 2738sec inet6 fe80::5054:ff:fe24:e558/64 scope link valid_lft forever preferred_lft forever 3: enp0s7: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default qlen 1000 link/ether 52:54:00:96:d9:83 brd ff:ff:ff:ff:ff:ff After Detaching the Interface: ================================= # virsh detach-interface Ubuntu2404 bridge 52:54:00:96:d9:83 Interface detached successfully root@ubuntu:~# ip addr 1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000 link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 inet 127.0.0.1/8 scope host lo valid_lft forever preferred_lft forever inet6 ::1/128 scope host noprefixroute valid_lft forever preferred_lft forever 2: enp0s1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000 link/ether 52:54:00:24:e5:58 brd ff:ff:ff:ff:ff:ff inet 192.168.122.187/24 metric 100 brd 192.168.122.255 scope global dynamic enp0s1 valid_lft 2720sec preferred_lft 2720sec inet6 fe80::5054:ff:fe24:e558/64 scope link valid_lft forever preferred_lft forever ** Tags removed: verification-needed-noble-linux ** Tags added: verification-done-noble-linux -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/2074376 Title: Disable PCI_DYNAMIC_OF_NODES in Ubuntu Status in linux package in Ubuntu: Fix Committed Status in linux source package in Noble: Fix Committed Status in linux source package in Oracular: Fix Committed Bug description: This came in via KTML from upstream. It is part of a discussion between upstream and IBM reporting a bug which occurs in KVM: Rob Herring <r...@kernel.org> writes: >> On 2024/07/11 06:20 AM, Rob Herring wrote: >>> On Wed, Jul 3, 2024 at 8:17 AM Amit Machhiwal <amach...@linux.ibm.com> wrote: >>>> >>>> With CONFIG_PCI_DYNAMIC_OF_NODES [1], a hot-plug and hot-unplug sequence >>>> of a PCI device attached to a PCI-bridge causes following kernel Oops on >>>> a pseries KVM guest: >>> >>> Can I ask why you have this option on in the first place? Do you have >>> a use for it or it's just a case of distros turn on every kconfig >>> option. >> >> Yes, this option is turned on in Ubuntu's distro kernel config where the issue >> was originally reported, while Fedora is keeping this turned off. >> >> root@ubuntu:~# cat /boot/config-6.8.0-38-generic | grep PCI_DYN >> CONFIG_PCI_DYNAMIC_OF_NODES=y > > Ubuntu should turn off this option. For starters, it is not complete > to be usable. Eventually, it should get removed in favor of some TBD > runtime option. > > (And we should fix the crash too) This option is described in the config system as: This option enables support for generating device tree nodes for some PCI devices. Thus, the driver of this kind can load and overlay flattened device tree for its downstream devices. . Once this option is selected, the device tree nodes will be generated for all PCI bridges. Open Firmware (OF) would be used for KVM for UEFI mode. The reported bug was related to hot-unplugging PCI devices. My guess would be that this probably is not of much use to the majority of users and might even go away. So it should really be disabled in Ubuntu, too. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2074376/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
