Analyze for merge readiness: The current delta is: * d/p/0001-ucm2-Qualcomm-sc8280xp-fix-device-numbers.patch * d/p/0001-acp63-add-initial-support-for-AMD-Pink-Sardine-ACP63.patch * d/p/0002-acp63.conf-use-symbolic-link.patch * d/p/0003-acp62-add-initial-support-for-AMD-ACP-v6.2-RPL.patch => Those are in 1.2.10 and can be dropped on a merge
* d/p/0001-Add-initial-support-for-MediaTek-mt8390-evk-and-mt83.patch => This is not upstream AFAICS => It does not have the dep-3 patch headers for Forwarded or Origin and sadly such moments trying to find what happened is just why they should always be added. This is a sin of the past and not your fault Artur, but your patch also misses those, so let me teach you about that ... Learning links: - Standard for patch headers: https://dep-team.pages.debian.net/deps/dep3/ - If you want it a bit more consumable https://github.com/canonical/ubuntu-maintainers-handbook/blob/a5a386be1be1507fbd1dd8842699b0758042169c/DebianPatch.md#the-patchfile-header Also your git export is not of the hash that is in the final repository Instead it is from the PR which might go away and is therefore harder to find. And finally, no trace back from the patch to the bug that made it being added. So overall your patch should ideally be like: - use correct git hash - add Origin - add Applied-Upstream - Add last-update Which makes it start like: From b422a8e08cb3845053ece1fc832294adca21a684 Mon Sep 17 00:00:00 2001 From: Shuming Fan <shumi...@realtek.com> Date: Thu, 12 Oct 2023 10:07:36 +0800 Subject: [PATCH] ucm2: soundwire: add rt713 SDCA device Closes: https://github.com/alsa-project/alsa-ucm-conf/pull/363 Signed-off-by: Shuming Fan <shumi...@realtek.com> Signed-off-by: Jaroslav Kysela <pe...@perex.cz> Origin: upstream, https://github.com/alsa-project/alsa-ucm-conf/commit/b422a8e08cb3845053ece1fc832294adca21a684 Bug: https://bugs.launchpad.net/ubuntu/+source/alsa-ucm-conf/+bug/2042902 Applied-Upstream: v1.2.11 Last-Update: 2023-11-24 --- ... I'll do that for you here for noble to make some progress, but you can still fix this up for the SRU uploads. It really would have helped if you'd have been available after you pinged me on IRC. At the end of the day we want to teach, not just correct uploads. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to alsa-ucm-conf in Ubuntu. https://bugs.launchpad.net/bugs/2042902 Title: ucm2: soundwire: add rt713 SDCA device Status in OEM Priority Project: In Progress Status in alsa-ucm-conf package in Ubuntu: Fix Committed Status in alsa-ucm-conf source package in Jammy: New Status in alsa-ucm-conf source package in Lunar: New Status in alsa-ucm-conf source package in Mantic: New Status in alsa-ucm-conf source package in Noble: Fix Committed Bug description: [ Impact ] Affects devices with SoundWire-Audio Codec-ALC713 and SoundWire-Jack Codec-ALC713. Without correct configurations in userspace above codecs cannot be used. Thus in Settings > Sound > Output test doesn't produce sounds and Input device is greyed out. [ Fix ] Adding rt713 config files in ucm2 will allow to utilize those codecs. Upstream commit added support: https://github.com/alsa-project/alsa-ucm-conf/pull/363 [ Test Plan ] Device with the soundwire card $ cat /proc/asound/cards 0 [sofsoundwire ]: sof-soundwire - sof-soundwire Intel Soundwire SOF Before fix: 1. $ alsactl init alsa-lib utils.c:364:(uc_mgr_config_load_into) could not open configuration file /usr/share/alsa/ucm2/sof-soundwire/rt713.conf alsa-lib parser.c:77:(uc_mgr_config_load_file) error: failed to open file /usr/share/alsa/ucm2/sof-soundwire/rt713.conf: -2 alsa-lib main.c:1412:(snd_use_case_mgr_open) error: failed to import hw:0 use case configuration -2 Found hardware: "sof-soundwire" "Intel Meteorlake HDMI" "HDA:8086281d,80860101,00100000 cfg-spk:2 cfg-amp:2 hs:rt713-sdca spk:rt1316 mic:rt713-dmic" "" "" Hardware is initialized using a generic method 2. $ amixer contents ... numid=24,iface=MIXER,name='Headphone Switch' ; type=BOOLEAN,access=rw------,values=1 : values=off ... numid=33,iface=MIXER,name='IEC958 Playback Switch' ; type=BOOLEAN,access=rw------,values=1 : values=off After fix: after adding patch files 1. $ alsactl init alsa-lib main.c:779:(execute_sequence) exec '/bin/rm -rf /var/lib/alsa/card0.conf.d' failed (exit code 1) (note: assuming that failed to remove the empty directory is not a critical problem) 2. $ amixer contents ... numid=24,iface=MIXER,name='Headphone Switch' ; type=BOOLEAN,access=rw------,values=1 : values=on ... numid=33,iface=MIXER,name='IEC958 Playback Switch' ; type=BOOLEAN,access=rw------,values=1 : values=on [Where problems could occur] * This change adds new hardware support. * The change only adds new hardware support, it will not affect other codec device. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/2042902/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
