Hello Colin, or anyone else affected,

Accepted zfs-linux into hirsute-proposed. The package will build now and
be available at https://launchpad.net/ubuntu/+source/zfs-
linux/2.0.2-1ubuntu5.2 in a few hours, and then in the -proposed
repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
hirsute to verification-done-hirsute. If it does not fix the bug for
you, please add a comment stating that, and change the tag to
verification-failed-hirsute. In either case, without details of your
testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: zfs-linux (Ubuntu Hirsute)
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to zfs-linux in Ubuntu.
https://bugs.launchpad.net/bugs/1942991

Title:
  zfs: can't read /proc/sys/kernel/spl/hostid

Status in zfs-linux package in Ubuntu:
  Fix Released
Status in zfs-linux source package in Hirsute:
  Fix Committed
Status in zfs-linux source package in Impish:
  Fix Released

Bug description:
  [Impact]

  Reading /proc/sys/kernel/spl/hostid no longer works in 5.7+ kernels
  upwards.

  The Fix:

  commit 7de4c88b39473f358add601e8c227ca9002b1bee
  Author: наб <nabijaczlew...@nabijaczleweli.xyz>
  Date:   Sun Apr 11 01:18:40 2021 +0200
  linux/spl: base proc_dohostid() on proc_dostring()

      This fixes /proc/sys/kernel/spl/hostid on kernels with mainline commit
      32927393dc1ccd60fb2bdc05b9e8e88753761469 ("sysctl: pass kernel pointers
      to ->proc_handler") ‒ 5.7-rc1 and up

      The access_ok() check in copy_to_user() in proc_copyout_string() would
      always fail, so all userspace reads and writes would fail with EINVAL

      proc_dostring() strips only the final new-line,
      but simple_strtoul() doesn't actually need a back-trimmed string ‒
      writing "012345678   \n" is still allowed, as is "012345678zupsko", &c.

      This alters what happens when an invalid value is written ‒
      previously it'd get set to what-ever simple_strtoul() returned
      (probably 0, thereby resetting it to default), now it does nothing

      Reviewed-by: Brian Behlendorf <behlendo...@llnl.gov>
      Signed-off-by: Ahelenia Ziemiańska <nabijaczlew...@nabijaczleweli.xyz>
      Closes #11878
      Closes #11879

  
  This applies cleanly for Impish and Hirsute 2.x ZFS so backporting is 
straight forward.

  [Test Plan]

  cat /proc/sys/kernel/spl/hostid fails without the fix. With the fix it
  returns a hex string of the hostid value.

  [Where problems could occur]

  This affects just a few /proc spl interfaces so the change is a low-
  impact fix. Not many folk even use these and nobody has reported this
  as a bug so the number of affected users is expected to be very small.
  I suspect nobody is reading the hostid from /proc as this information
  is available elsewhere and it's rather an old legacy interface.

  The affected change is from upstream ZFS 2.x hence the patch applies
  cleanly.

  This fix has been in upstream ZFS for several months with no reported
  regressions.

  The change does not affect any core ZFS functionality.

  Regression tested against the Ubuntu ZFS regression test suite and
  passed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1942991/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to     : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to