So, while looking further, I found out that 1aa12bdf1bfb ("bpf: sockmap, add sock close() hook to remove socks") is not even present on our 4.15 kernels. Not sure why the two commits were backported. The tcp,ulp one seems fine to keep.
Even 952fad8e3239 ("bpf: fix sock_map_alloc() error path") is not necessary if we are not setting err right before, which we do with 1aa12bdf1bfb. Other patches do not even apply, they are really dependent on 1aa12bdf1bfb. 1aa12bdf1bfb, on the other hand, would be necessary, because I was able to reproduce a BPF program leak. But that requires the use of sockmap, which is restricted to root userns CAP_NET_ADMIN. So, we need to pick 1aa12bdf1bfb and all of those fixes, or simply revert 5028027844cf ("bpf: test_maps, only support ESTABLISHED socks"). -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1839912 Title: test_map in ubuntu_bpf failed with "Allowed update sockmap '0:3' not in ESTABLISHED" Status in ubuntu-kernel-tests: New Status in linux package in Ubuntu: Confirmed Status in linux source package in Bionic: New Bug description: This is at lease a test case regression with the proposed kernel: selftests: test_maps ======================================== Allowed update sockmap '0:3' not in ESTABLISHED not ok 1..3 selftests: test_maps [FAIL] But with older kernel: selftests: test_maps ======================================== test_maps: OK ok 1..3 selftests: test_maps [PASS] ProblemType: Bug DistroRelease: Ubuntu 18.04 Package: linux-image-4.15.0-58-generic 4.15.0-58.64 ProcVersionSignature: User Name 4.15.0-58.64-generic 4.15.18 Uname: Linux 4.15.0-58-generic x86_64 AlsaDevices: total 0 crw-rw---- 1 root audio 116, 1 Aug 13 03:42 seq crw-rw---- 1 root audio 116, 33 Aug 13 03:42 timer AplayDevices: Error: [Errno 2] No such file or directory: 'aplay': 'aplay' ApportVersion: 2.20.9-0ubuntu7.7 Architecture: amd64 ArecordDevices: Error: [Errno 2] No such file or directory: 'arecord': 'arecord' AudioDevicesInUse: Error: command ['fuser', '-v', '/dev/snd/seq', '/dev/snd/timer'] failed with exit code 1: Date: Tue Aug 13 03:52:52 2019 IwConfig: Error: [Errno 2] No such file or directory: 'iwconfig': 'iwconfig' MachineType: Intel Corporation S1200RP PciMultimedia: ProcFB: 0 mgadrmfb ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-4.15.0-58-generic root=UUID=b0d2ae4e-12dd-423e-acea-272ee8b2a893 ro RelatedPackageVersions: linux-restricted-modules-4.15.0-58-generic N/A linux-backports-modules-4.15.0-58-generic N/A linux-firmware 1.173.10 RfKill: Error: [Errno 2] No such file or directory: 'rfkill': 'rfkill' SourcePackage: linux UpgradeStatus: No upgrade log present (probably fresh install) dmi.bios.date: 07/01/2015 dmi.bios.vendor: Intel Corp. dmi.bios.version: S1200RP.86B.03.02.0003.070120151022 dmi.board.asset.tag: .................... dmi.board.name: S1200RP dmi.board.vendor: Intel Corporation dmi.board.version: G62254-407 dmi.chassis.asset.tag: .................... dmi.chassis.type: 17 dmi.chassis.vendor: .............................. dmi.chassis.version: .................. dmi.modalias: dmi:bvnIntelCorp.:bvrS1200RP.86B.03.02.0003.070120151022:bd07/01/2015:svnIntelCorporation:pnS1200RP:pvr....................:rvnIntelCorporation:rnS1200RP:rvrG62254-407:cvn..............................:ct17:cvr..................: dmi.product.family: To be filled by O.E.M. dmi.product.name: S1200RP dmi.product.version: .................... dmi.sys.vendor: Intel Corporation To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1839912/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp