Public bug reported:

[Impact]
Reading speed and duplex sysfs on igc device when it's runtime suspended
will make it stops working. Even kernel panic sometimes.

[Fix]
If igc device is runtime suspended, it means link isn't up, so we can
just report speed as -1 and duplex as unknown.

[Test]
$ cat /sys/class/net/*/speed
Then we'll see:
[  123.449883] igc 0000:03:00.0 enp3s0: PCIe link lost, device now detached
[  123.450052] BUG: kernel NULL pointer dereference, address: 0000000000000008

With the fix applied,
$ cat /sys/class/net/*/speed
-1

[Where problems could occur]
Not at all. Reading register when device is runtime suspended is just
wrong. The fix prevents it from happening.

** Affects: hwe-next
     Importance: Undecided
         Status: New

** Affects: linux (Ubuntu)
     Importance: Undecided
         Status: New

** Affects: linux-oem-5.10 (Ubuntu)
     Importance: Undecided
         Status: Invalid

** Affects: linux-oem-5.6 (Ubuntu)
     Importance: Undecided
         Status: Invalid

** Affects: linux (Ubuntu Focal)
     Importance: Medium
         Status: Confirmed

** Affects: linux-oem-5.10 (Ubuntu Focal)
     Importance: Medium
         Status: Confirmed

** Affects: linux-oem-5.6 (Ubuntu Focal)
     Importance: Medium
         Status: Confirmed

** Affects: linux (Ubuntu Groovy)
     Importance: Medium
         Status: Confirmed

** Affects: linux-oem-5.10 (Ubuntu Groovy)
     Importance: Undecided
         Status: Won't Fix

** Affects: linux-oem-5.6 (Ubuntu Groovy)
     Importance: Undecided
         Status: Won't Fix


** Tags: oem-priority originate-from-1904532 somerville

** Also affects: linux-oem-5.6 (Ubuntu)
   Importance: Undecided
       Status: New

** Also affects: linux-oem-5.10 (Ubuntu)
   Importance: Undecided
       Status: New

** Also affects: linux (Ubuntu Focal)
   Importance: Undecided
       Status: New

** Also affects: linux-oem-5.6 (Ubuntu Focal)
   Importance: Undecided
       Status: New

** Also affects: linux-oem-5.10 (Ubuntu Focal)
   Importance: Undecided
       Status: New

** Also affects: linux (Ubuntu Groovy)
   Importance: Undecided
       Status: New

** Also affects: linux-oem-5.6 (Ubuntu Groovy)
   Importance: Undecided
       Status: New

** Also affects: linux-oem-5.10 (Ubuntu Groovy)
   Importance: Undecided
       Status: New

** Changed in: linux-oem-5.10 (Ubuntu Groovy)
       Status: New => Won't Fix

** Changed in: linux-oem-5.6 (Ubuntu Groovy)
       Status: New => Won't Fix

** Changed in: linux-oem-5.10 (Ubuntu)
       Status: New => Invalid

** Changed in: linux-oem-5.6 (Ubuntu)
       Status: New => Invalid

** Changed in: linux (Ubuntu Focal)
       Status: New => Confirmed

** Changed in: linux (Ubuntu Groovy)
       Status: New => Confirmed

** Changed in: linux-oem-5.10 (Ubuntu Focal)
       Status: New => Confirmed

** Changed in: linux-oem-5.6 (Ubuntu Focal)
       Status: New => Confirmed

** Changed in: linux (Ubuntu Focal)
   Importance: Undecided => Medium

** Changed in: linux-oem-5.10 (Ubuntu Focal)
   Importance: Undecided => Medium

** Changed in: linux-oem-5.6 (Ubuntu Focal)
   Importance: Undecided => Medium

** Changed in: linux (Ubuntu Groovy)
   Importance: Undecided => Medium

** Tags added: oem-priority originate-from-1904532 somerville

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1906851

Title:
  Fix reading speed and duplex sysfs on igc device

Status in HWE Next:
  New
Status in linux package in Ubuntu:
  New
Status in linux-oem-5.10 package in Ubuntu:
  Invalid
Status in linux-oem-5.6 package in Ubuntu:
  Invalid
Status in linux source package in Focal:
  Confirmed
Status in linux-oem-5.10 source package in Focal:
  Confirmed
Status in linux-oem-5.6 source package in Focal:
  Confirmed
Status in linux source package in Groovy:
  Confirmed
Status in linux-oem-5.10 source package in Groovy:
  Won't Fix
Status in linux-oem-5.6 source package in Groovy:
  Won't Fix

Bug description:
  [Impact]
  Reading speed and duplex sysfs on igc device when it's runtime suspended
  will make it stops working. Even kernel panic sometimes.

  [Fix]
  If igc device is runtime suspended, it means link isn't up, so we can
  just report speed as -1 and duplex as unknown.

  [Test]
  $ cat /sys/class/net/*/speed
  Then we'll see:
  [  123.449883] igc 0000:03:00.0 enp3s0: PCIe link lost, device now detached
  [  123.450052] BUG: kernel NULL pointer dereference, address: 0000000000000008

  With the fix applied,
  $ cat /sys/class/net/*/speed
  -1

  [Where problems could occur]
  Not at all. Reading register when device is runtime suspended is just
  wrong. The fix prevents it from happening.

To manage notifications about this bug go to:
https://bugs.launchpad.net/hwe-next/+bug/1906851/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to     : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to