between 5.3 and 5.4 there are many changes in
drivers/net/ethernet/realtek

$ git log --format="%h %cd %s" --date=short 5.3-main..5.4-main -- 
drivers/net/ethernet/realtek/
44ee727013d5 2020-05-20 r8169: re-establish support for RTL8401 chip version
74107d56d1e8 2020-04-13 r8169: change back SG and TSO to be disabled by default
791c420f4228 2020-04-01 r8169: fix PHY driver check on platforms w/o module 
softdeps
4cc2498b7ebb 2020-04-01 r8169: re-enable MSI on RTL8168c
58bc57b373e0 2020-02-24 r8169: check that Realtek PHY driver module is loaded
0ed50cdcb505 2019-12-31 r8169: respect EEE user setting when restarting network
68159412b26e 2019-12-18 r8169: add missing RX enabling for WoL on RTL8125
dc63e75e19d3 2019-12-17 r8169: fix rtl_hw_jumbo_disable for RTL8168evl
2840e52f679a 2019-12-04 r8169: fix resume on cable plug-in
c07fd3caadc3 2019-12-04 r8169: fix jumbo configuration for RTL8168evl
a0783cd0c810 2019-11-19 r8169: disable TSO on a single version of RTL8168c to 
fix performance
9c6850fea3ed 2019-11-06 r8169: fix page read in r8168g_mdio_read
62bdc8fd1c21 2019-11-01 r8169: fix wrong PHY ID issue with RTL8168dp
4ebcb113edcc 2019-10-10 r8169: fix jumbo packet handling on resume from suspend
299d14d4c31a 2019-09-23 Merge tag 'pci-v5.4-changes' of 
git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci
dc161162e42c 2019-09-01 r8169: don't set bit RxVlan on RTL8125
b3a42e3a78ce 2019-08-29 r8169: add support for EEE on RTL8125
02bf642b188a 2019-08-29 r8169: add RTL8125 PHY initialization
f1bce4ad2f1c 2019-08-29 r8169: add support for RTL8125
ae84bc187337 2019-08-29 r8169: don't use bit LastFrag in tx descriptor after 
send
7366016d2d4c 2019-08-29 r8169: read common register for PCI commit
bcf2b868a5ae 2019-08-29 r8169: move disabling interrupt coalescing to 
RTL8169/RTL8168 init
ce37115e3a57 2019-08-29 r8169: factor out reading MAC address from registers
c623305bf465 2019-08-29 r8169: restrict rtl_is_8168evl_up to RTL8168 chip 
versions
c1d532d268cb 2019-08-29 r8169: change interrupt mask type to u32
7ce2e76a0420 2019-08-28 PCI: Move ASPM declarations to linux/pci.h
3c95e5013b7f 2019-08-26 r8169: improve DMA handling in rtl_rx
d4ed7463d02a 2019-08-23 r8169: fix DMA issue on MIPS platform
b6cef26fb909 2019-08-15 r8169: sync EEE handling for RTL8168h with vendor driver
2e779ddb5617 2019-08-15 r8169: use the generic EEE management functions
4773f9bdb476 2019-08-14 r8169: fix sporadic transmit timeout issue
eb2e7f092271 2019-08-11 r8169: inline rtl8169_free_rx_databuff
a7eb6a4f2560 2019-08-09 r8169: fix performance issue on RTL8168evl
32879f000120 2019-08-08 r8169: allocate rx buffers using alloc_pages_node
13dfb3fa4943 2019-08-06 Merge 
git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
a7a92cf81589 2019-08-06 r8169: sync PCIe PHY init with vendor driver 8.047.01
ef712ede3541 2019-08-06 r8169: add helper r8168_mac_ocp_modify
a14cc4d24a64 2019-08-06 r8169: remove access to legacy register MultiIntr
ef14358546b1 2019-07-29 r8169: make use of xmit_more
93681cd7d94f 2019-07-27 r8169: enable HW csum and TSO
96ea772ef241 2019-07-27 r8169: remove r8169_csum_workaround
e64e0c897499 2019-07-27 r8169: implement callback ndo_features_check
0170d594ded8 2019-07-27 r8169: set GSO size and segment limits
edcde3ee579b 2019-07-27 r8169: align setting PME with vendor driver
81cd17a4121d 2019-07-24 r8169: improve rtl_set_rx_mode
ed72a9bb9af0 2019-07-24 r8169: fix a typo in a comment
fcd4e60885af 2019-07-22 r8169: improve rtl_rx

some changes that may break on a quick diff:

static void rtl8169_irq_mask_and_ack(struct rtl8169_private *tp)
 {
        rtl_irq_disable(tp);
-       rtl_ack_events(tp, 0xffff);
+       rtl_ack_events(tp, 0xffffffff);


 static void rtl_set_rx_mode(struct net_device *dev)
 {
+       u32 rx_mode = AcceptBroadcast | AcceptMyPhys | AcceptMulticast;
+       /* Multicast hash filter */
+       u32 mc_filter[2] = { 0xffffffff, 0xffffffff };
        struct rtl8169_private *tp = netdev_priv(dev);
-       u32 mc_filter[2];       /* Multicast hash filter */
-       int rx_mode;
-       u32 tmp = 0;
+       u32 tmp;
....


static void rtl_hw_start_*

-       if (tp->dev->mtu <= ETH_DATA_LEN)
-               rtl_tx_performance_tweak(tp, PCI_EXP_DEVCTL_READRQ_4096B);

if we can compile a kernel directly from kernel.org we can revert some
of these commits and test which one is causing that issue. but i found
not yet a manual how to compile using mainline-sources directly.

config is (at least in 18.4) /boot/config-5.3.0-59-generic

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1880076

Title:
  ubuntu 20.4 - retransmitts with r8169

Status in linux package in Ubuntu:
  Incomplete

Bug description:
  Hi,

  i run some network-tests (iperf3) and noticed massive retransmitts in
  ubuntu 20.4 with kernel 5.4.0-29. I'm using module r8169 for network-
  adapter

  03:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd.
  RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller (rev 15)

  if i boot my ubuntu 18.4 and did same iperf-test (same hardware, same
  network configuration, other client is not rebooted) i have not these
  retransmitts.

  root@bpi-r2:~# iperf3 -c 192.168.0.21                                         
  
  Connecting to host 192.168.0.21, port 5201                                    
  
  [  5] local 192.168.0.11 port 35702 connected to 192.168.0.21 port 5201       
  
  [ ID] Interval           Transfer     Bitrate         Retr  Cwnd              
  
  [  5]   0.00-1.00   sec  14.2 MBytes   119 Mbits/sec  337   14.1 KBytes       
  
  [  5]   1.00-2.00   sec  14.9 MBytes   125 Mbits/sec  331   14.1 KBytes       
  
  [  5]   2.00-3.00   sec  15.1 MBytes   126 Mbits/sec  296   19.8 KBytes       
  
  [  5]   3.00-4.00   sec  14.7 MBytes   124 Mbits/sec  314   14.1 KBytes       
  
  [  5]   4.00-5.00   sec  12.8 MBytes   107 Mbits/sec  259   14.1 KBytes       
  
  [  5]   5.00-6.01   sec  67.4 MBytes   560 Mbits/sec  137    362 KBytes       
  
  [  5]   6.01-7.00   sec   111 MBytes   940 Mbits/sec    0    366 KBytes       
  
  [  5]   7.00-8.00   sec   112 MBytes   941 Mbits/sec    0    409 KBytes       
  
  [  5]   8.00-9.00   sec   112 MBytes   940 Mbits/sec    0    421 KBytes       
  
  [  5]   9.00-10.00  sec   112 MBytes   936 Mbits/sec    0    426 KBytes       
  
  - - - - - - - - - - - - - - - - - - - - - - - - -                             
  
  [ ID] Interval           Transfer     Bitrate         Retr                    
  
  [  5]   0.00-10.00  sec   586 MBytes   491 Mbits/sec  1674             sender 
  
  [  5]   0.00-10.01  sec   585 MBytes   491 Mbits/sec                  
receiver  
                                                                                
  
  iperf Done.

  2: enp3s0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP 
group default qlen 1000
      link/ether e4:b9:7a:f7:c4:8b brd ff:ff:ff:ff:ff:ff
      inet 192.168.0.21/24 brd 192.168.0.255 scope global dynamic noprefixroute 
enp3s0
         valid_lft 171856sec preferred_lft 171856sec
      inet6 fe80::781a:829f:5030:ad6a/64 scope link noprefixroute 
         valid_lft forever preferred_lft forever

  $ ethtool -S enp3s0 
  NIC statistics:
       tx_packets: 571053
       rx_packets: 1184934
       tx_errors: 0
       rx_errors: 0
       rx_missed: 1919  <<<<<<<<<<<<<<<<<<<<<<<<<<<
       align_errors: 0
       tx_single_collisions: 0
       tx_multi_collisions: 0
       unicast: 1184926
       broadcast: 6
       multicast: 2
       tx_aborted: 0
       tx_underrun: 0

  2: enp3s0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP 
mode DEFAULT group default qlen 1000
      link/ether e4:b9:7a:f7:c4:8b brd ff:ff:ff:ff:ff:ff
      RX: bytes  packets  errors  dropped overrun mcast   
      1785166133 1184970  0       0       0       2       
      TX: bytes  packets  errors  dropped carrier collsns 
      39395440   570500   0       0       0       0  

  on the other side i see dropped packets, maybe flowcontrol-related?

  ethtool reports "Link partner advertised pause frame use: Symmetric"
  but maybe flowcontrol is not working...

  also driver reports flowcontrol is enabled...

  $ dmesg | grep r8169
  [    0.939358] libphy: r8169: probed
  [    0.939491] r8169 0000:03:00.0 eth0: RTL8168h/8111h, e4:b9:7a:f7:c4:8b, 
XID 541, IRQ 128
  [    0.939492] r8169 0000:03:00.0 eth0: jumbo features [frames: 9200 bytes, 
tx checksumming: ko]
  [    0.986853] r8169 0000:03:00.0 enp3s0: renamed from eth0
  [    3.478981] Generic FE-GE Realtek PHY r8169-300:00: attached PHY driver 
[Generic FE-GE Realtek PHY] (mii_bus:phy_addr=r8169-300:00, irq=IGNORE)
  [    3.591124] r8169 0000:03:00.0 enp3s0: Link is Down
  [    7.171198] r8169 0000:03:00.0 enp3s0: Link is Up - 1Gbps/Full - flow 
control rx/tx

  ProblemType: Bug
  DistroRelease: Ubuntu 20.04
  Package: linux-image-5.4.0-29-generic 5.4.0-29.33
  ProcVersionSignature: Ubuntu 5.4.0-29.33-generic 5.4.30
  Uname: Linux 5.4.0-29-generic x86_64
  ApportVersion: 2.20.11-0ubuntu27
  Architecture: amd64
  AudioDevicesInUse:
   USER        PID ACCESS COMMAND
   /dev/snd/controlC0:  frank      1427 F.... pulseaudio
  CasperMD5CheckResult: skip
  CurrentDesktop: GNOME-Flashback:GNOME
  Date: Fri May 22 06:49:34 2020
  InstallationDate: Installed on 2020-04-27 (24 days ago)
  InstallationMedia: Ubuntu 20.04 LTS "Focal Fossa" - Release amd64 (20200423)
  MachineType: Dell Inc. G5 5590
  ProcEnviron:
   TERM=xterm-256color
   PATH=(custom, no user)
   XDG_RUNTIME_DIR=<set>
   LANG=de_DE.UTF-8
   SHELL=/bin/bash
  ProcFB: 0 i915drmfb
  ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-5.4.0-29-generic 
root=UUID=7c9113b7-ca65-4c46-9435-f5d2b73bab72 ro quiet
  RelatedPackageVersions:
   linux-restricted-modules-5.4.0-29-generic N/A
   linux-backports-modules-5.4.0-29-generic  N/A
   linux-firmware                            1.187
  SourcePackage: linux
  UpgradeStatus: No upgrade log present (probably fresh install)
  dmi.bios.date: 02/07/2020
  dmi.bios.vendor: Dell Inc.
  dmi.bios.version: 1.12.0
  dmi.board.name: 0KW84T
  dmi.board.vendor: Dell Inc.
  dmi.board.version: A00
  dmi.chassis.type: 10
  dmi.chassis.vendor: Dell Inc.
  dmi.modalias: 
dmi:bvnDellInc.:bvr1.12.0:bd02/07/2020:svnDellInc.:pnG55590:pvr:rvnDellInc.:rn0KW84T:rvrA00:cvnDellInc.:ct10:cvr:
  dmi.product.family: GSeries
  dmi.product.name: G5 5590
  dmi.product.sku: 08EA
  dmi.sys.vendor: Dell Inc.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1880076/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to     : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to