root@dut-vm:~# ip netns add foo
root@dut-vm:~# ip netns add bar
root@dut-vm:~# ip -n foo netns set bar 0
root@dut-vm:~# ip -n foo link add xfrmi0 link-netnsid 0 type xfrm dev lo if_id 
23
root@dut-vm:~# ip -n bar link ls xfrmi0
Device "xfrmi0" does not exist.
root@dut-vm:~# ip -n foo link ls xfrmi0
2: xfrmi0@if1: <NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group 
default qlen 1000
    link/none 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff link-netns bar

=> interface is correctly created and there is no backtrace in dmesg, OK


root@dut-vm:~# ip netns del foo
root@dut-vm:~# ip netns del bar
root@dut-vm:~# ip link add xfrm1 type xfrm dev lo if_id 1
root@dut-vm:~# ip link add xfrm2 type xfrm dev lo if_id 2
root@dut-vm:~# ip link set xfrm1 type xfrm dev lo if_id 2
RTNETLINK answers: File exists
root@dut-vm:~# ip -d link list dev xfrm1
7: xfrm1@lo: <NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group default 
qlen 1000
    link/none 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 
maxmtu 1500
    xfrm if_id 0x1 addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 
65536 gso_max_segs 65535

=> if_id 0x1 and no backtrace in dmesg, OK


root@dut-vm:~# ip link add dummy type dummy
root@dut-vm:~# ip link add xfrm1 type xfrm dev dummy if_id 1
root@dut-vm:~# ip l d dummy
root@dut-vm:~# ip -d l ls xfrm1
10: xfrm1@if9: <NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT group 
default qlen 1000
    link/none 3a:90:dc:59:76:c6 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 
maxmtu 1500
    xfrm if_id 0x1 addrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 
65536 gso_max_segs 65535
root@dut-vm:~#

=> no refcnt pb, OK

Our internal tests suite is also OK.

** Tags removed: verification-needed-disco
** Tags added: verification-done-disco

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1836261

Title:
  xfrm interface: several kernel panic

Status in linux package in Ubuntu:
  Incomplete
Status in linux source package in Disco:
  Fix Committed

Bug description:
  BugLink: https://bugs.launchpad.net/bugs/1836261

  [Impact]

  Upstream has recently received a number of bug fixes that resolve
  kernel panics, memory leaks, and list handling for virtual xfrm
  interfaces that were debuted in 4.19.

  [Test Case]

  3 of the 5 patches have test cases in their commit message for
  reproducing the fault they address.

  Another patch prevents including a stale name in the log files.

  And the other patch that doesn't have an explicit test case improves list
  handling.

  [Regression Potential]

  This patchset contains a nontrivial amount of changes. However, the
  heavier patches contain test cases that they resolve the regressions
  they were created for. They've been upstream since July and I don't
  see any follow up Fixes commits targeting these. The blast radius is
  "only" the xfrm interface but this is smoke tested and if any
  dependents rely on it for core functionality they might exercise it
  and would possibly notice any issues by now as well.

  Original bug description follows:
  --------------------------------------------

  There was several problems reported upstream:

  1/ 56c5ee1a5823: xfrm interface: fix memory leak on creation
  
https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=56c5ee1a5823

  2/ xfrm interface: avoid corruption on changelink
  http://patchwork.ozlabs.org/patch/1130240/

  3/ xfrm interface: ifname may be wrong in logs
  http://patchwork.ozlabs.org/patch/1130241/

  4/ xfrm interface: fix list corruption for x-netns
  http://patchwork.ozlabs.org/patch/1130385/

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1836261/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to     : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to