commit 9a77ef188b24742b595f69891b97d48dc997f5e2
Author: Louis Bouchard <louis.bouch...@canonical.com>
Date: Thu Jan 29 16:03:04 2015 +0100
[debian] Fix panic_on_oops faulty handling
Signed-off-by: Louis Bouchard <louis.bouch...@canonical.com>
diff --git a/debian/kdump-config b/debian/kdump-config
index 7ea26cab1c95..64489a74757f 100755
--- a/debian/kdump-config
+++ b/debian/kdump-config
@@ -310,9 +310,10 @@ function fadump_register()
logger -t $NAME "fadump registered successfully"
# Last step: make sure panic_on_oops is enabled
- if [ -x /sbin/sysctl -a "$KDUMP_SYSCTL" != " " ] ; then
- sysctl -w $KDUMP_SYSCTL >/dev/null
- fi
+ PANIC_ON_OOPS=`/sbin/sysctl kernel.panic_on_oops | cut -d" " -f3`
+ if [ $PANIC_ON_OOPS != "1" ] ; then
+ sysctl -w kernel.panic_on_oops=1 >/dev/null
+ fi
}
# Returns: none. prints warnings or exit
@@ -393,9 +394,11 @@ function kdump_load()
fi
# Last step: make sure panic_on_oops is enabled
- if [ -x /sbin/sysctl -a "$KDUMP_SYSCTL" != " " ] ; then
- sysctl -w $KDUMP_SYSCTL >/dev/null
- fi
+ PANIC_ON_OOPS=`/sbin/sysctl kernel.panic_on_oops | cut -d" " -f3`
+ if [ $PANIC_ON_OOPS != "1" ] ; then
+ sysctl -w kernel.panic_on_oops=1 >/dev/null
+ fi
+
}
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to makedumpfile in Ubuntu.
https://bugs.launchpad.net/bugs/1845048
Title:
/etc/default/kdump-tools KDUMP_SYSCTL does not set sysctl params
Status in makedumpfile package in Ubuntu:
New
Bug description:
[impact]
Documentation, and past behavior, for kdump-tools was that the
KDUMP_SYSCTL variable in the /etc/default/kdump-tools file would be
applied to the system kernel params at kdump 'load'. However this is
no longer true, and those params are no longer applied to the system's
kernel param settings.
[test case]
install linux-crashdump (and kdump-tools).
Edit the /etc/default/kdump-tools file to set the KDUMP_SYSCTL param
to something other than default, e.g.:
KDUMP_SYSCTL="kernel.panic_on_oops=1 kernel.panic_on_warn=1"
reboot, or unload/reload kdump, to pick up the changes to the file.
Check if the panic_on_warn param is set:
$ cat /proc/sys/kernel/panic_on_warn
0
the problem does not seem to be with sysctl, as manually calling it
does work:
$ KDUMP_SYSCTL="kernel.panic_on_oops=1 kernel.panic_on_warn=1"
$ cat /proc/sys/kernel/panic_on_warn
0
$ sudo sysctl -w $KDUMP_SYSCTL
kernel.panic_on_oops = 1
kernel.panic_on_warn = 1
$ cat /proc/sys/kernel/panic_on_warn
1
[regression potential]
TBD
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1845048/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
