** Changed in: linux (Ubuntu Bionic)
Status: Incomplete => Fix Committed
** Changed in: linux (Ubuntu Cosmic)
Status: Incomplete => Fix Committed
** Changed in: linux (Ubuntu Disco)
Status: Incomplete => Fix Committed
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1830587
Title:
Reduce NAPI weight in hns driver from 256 to 64
Status in linux package in Ubuntu:
Incomplete
Status in linux source package in Bionic:
Fix Committed
Status in linux source package in Cosmic:
Fix Committed
Status in linux source package in Disco:
Fix Committed
Status in linux source package in Eoan:
Incomplete
Bug description:
[Impact]
We have a warning[1] in dmesg shows hns register napi as weight 256 but not
recommended. According to this commit[2] we shall use weight 64 as suggested.
[1] netif_napi_add() called with weight 256
[2]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=82dc3c63c692b1e1d59378ecee948ac88e034aad
[Test Case]
dmesg | grep netif_napi_add
[Fix]
commit acb1ce15a61154aa501891d67ebf79bc9ea26818
Author: Yonglong Liu <[email protected]>
Date: Thu Apr 4 16:46:43 2019 +0800
net: hns: Use NAPI_POLL_WEIGHT for hns driver
When the HNS driver loaded, always have an error print:
"netif_napi_add() called with weight 256"
This is because the kernel checks the NAPI polling weights
requested by drivers and it prints an error message if a driver
requests a weight bigger than 64.
So use NAPI_POLL_WEIGHT to fix it.
Signed-off-by: Yonglong Liu <[email protected]>
Signed-off-by: Peng Li <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
[Regression Risk]
Only weight for NAPI changed. Lowest regression risk.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1830587/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
