Sorry, I'm unable to verify this for xenial. I submitted it as an SRU
back to 4.4 because it had already landed in the stable queue for 4.4,
and is a trivial change[*]. I think we'd need a system that either uses
mvsas or aix94xx to actually exercise this libsas code on 4.4.

I do have a system that uses the hisi_sas driver, which also uses
libsas. That driver did not exist in 4.4. I gave backporting that driver
a go, but it was coded w/ the pci_irq_vector API that came later.

[*] https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-
queue.git/tree/queue-4.4/scsi-libsas-fix-rphy-phy_identifier-for-phys-
with-end-devices-attached.patch

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1817784

Title:
  libsas disks can have non-unique by-path names

Status in linux package in Ubuntu:
  Fix Committed
Status in linux source package in Xenial:
  Fix Committed
Status in linux source package in Bionic:
  Fix Committed
Status in linux source package in Cosmic:
  Fix Committed
Status in linux source package in Disco:
  Fix Committed

Bug description:
  [Impact]
  Multiple disks in a system can end up having the same BY_PATH name, making 
the corresponding symlinks in /dev/disk/by-path non-unique. This can result in 
a user performing an operation on the wrong disk, possibly resulting in data 
loss.

  [Test Case]
  $ ls -l /dev/disk/by-path/
  total 0
  lrwxrwxrwx 1 root root  9 Feb 13 12:26 
platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy0-lun-0 -> ../../sdb
  lrwxrwxrwx 1 root root 10 Feb 13 12:26 
platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy0-lun-0-part1 -> ../../sdb1
  lrwxrwxrwx 1 root root 10 Feb 13 12:26 
platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy0-lun-0-part2 -> ../../sdb2
  lrwxrwxrwx 1 root root 10 Feb 13 12:26 
platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy0-lun-0-part3 -> ../../sdc3

  
  Notice that there is no symlink for /dev/sdc.

  [Fix]
  ffeafdd2bf0b2 scsi: libsas: Fix rphy phy_identifier for PHYs with end devices 
attached

  [Regression Risk]
  This may change the by-path symlinks for disks on the system. While the new 
name would be the correct one - users maybe relying on the incorrect version. 
This could result in an unbootable system, requiring manual intervention to 
repair.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1817784/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to     : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to