09:31:32 ERROR| [stderr] Test to ensure all modules are built with retpoline on
x86 ... FAIL
09:31:32 ERROR| [stderr]
09:31:32 ERROR| [stderr]
======================================================================
09:31:32 ERROR| [stderr] FAIL: test_350_retpolined_modules
(__main__.KernelSecurityTest)
09:31:32 ERROR| [stderr] Test to ensure all modules are built with retpoline on
x86
09:31:32 ERROR| [stderr]
----------------------------------------------------------------------
09:31:32 ERROR| [stderr] Traceback (most recent call last):
09:31:32 ERROR| [stderr] File "./test-kernel-security.py", line 2040, in
test_350_retpolined_modules
09:31:32 ERROR| [stderr] raise self.failureException('Module %s not
compiled with retpoline:\n%s' % (module, error_output))
09:31:32 ERROR| [stderr] AssertionError: Module
/lib/modules/4.19.0-9-generic/kernel/ubuntu/hio/hio.ko not compiled with
retpoline:
09:31:32 ERROR| [stderr] Command: 'modinfo', '-k', '4.19.0-9-generic',
'/lib/modules/4.19.0-9-generic/kernel/ubuntu/hio/hio.ko'
09:31:32 ERROR| [stderr] Output:
09:31:32 ERROR| [stderr] filename:
/lib/modules/4.19.0-9-generic/kernel/ubuntu/hio/hio.ko
09:31:32 ERROR| [stderr] description: Huawei SSD driver
09:31:32 ERROR| [stderr] author: Huawei SSD DEV Team
09:31:32 ERROR| [stderr] license: GPL
09:31:32 ERROR| [stderr] version: 2.1.0.40
09:31:32 ERROR| [stderr] srcversion: 8CF2BD2E0E6A8CB9DD5E764
09:31:32 ERROR| [stderr] alias: pci:v000019E5d0000000Asv*sd*bc*sc*i*
09:31:32 ERROR| [stderr] alias: pci:v000019E5d00000009sv*sd*bc*sc*i*
09:31:32 ERROR| [stderr] alias: pci:v000019E5d00000007sv*sd*bc*sc*i*
09:31:32 ERROR| [stderr] alias: pci:v000010EEd00000007sv*sd*bc*sc*i*
09:31:32 ERROR| [stderr] depends:
09:31:32 ERROR| [stderr] intree: Y
09:31:32 ERROR| [stderr] name: hio
09:31:32 ERROR| [stderr] vermagic: 4.19.0-9-generic SMP mod_unload
09:31:32 ERROR| [stderr] sig_id: PKCS#7
09:31:32 ERROR| [stderr] signer:
09:31:32 ERROR| [stderr] sig_key:
09:31:32 ERROR| [stderr] sig_hashalgo: md4
It happens with every module, not only hio.
Here is the relevant code from modpost:
/* Cannot check for assembler */
static void add_retpoline(struct buffer *b)
{
buf_printf(b, "\n#ifdef RETPOLINE\n");
buf_printf(b, "MODULE_INFO(retpoline, \"Y\");\n");
buf_printf(b, "#endif\n");
}
And the relevant diff from commit
4cd24de3a0980bf3100c9dcb08ef65ca7c31af48 upstream:
-ifneq ($(RETPOLINE_CFLAGS),)
- KBUILD_CFLAGS += $(RETPOLINE_CFLAGS) -DRETPOLINE
+ifeq ($(RETPOLINE_CFLAGS),)
+ $(error You are building kernel with non-retpoline compiler, please update
your compiler.)
endif
+ KBUILD_CFLAGS += $(RETPOLINE_CFLAGS)
endif
** Also affects: linux (Ubuntu Disco)
Importance: Undecided
Status: New
** Changed in: linux (Ubuntu Disco)
Assignee: (unassigned) => Thadeu Lima de Souza Cascardo (cascardo)
** Changed in: linux (Ubuntu Disco)
Status: New => In Progress
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1808567
Title:
modules do not have retpoline modinfo
Status in linux package in Ubuntu:
In Progress
Status in linux source package in Disco:
In Progress
Bug description:
Even though they are built with CONFIG_RETPOLINE, modpost won't
correctly insert the MODULE_INFO after CONFIG_RETPOLINE was made
dependent on compiler support.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1808567/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
