Public bug reported: SRU Justification:
Impact: The backport of a78ee256c325 ("xfs: convert XFS_AGFL_SIZE to a helper function") done as part of "Bionic update: upstream stable patchset 2018-08-24" (bug 1788897) is incomplete, causing the build to fail if CONFIG_XFS_ONLINE_SCRUB is selected. /tmp/kernel-kleber-79aa9f7-Y9dG/build/fs/xfs/scrub/agheader.c: In function 'xfs_scrub_walk_agfl': /tmp/kernel-kleber-79aa9f7-Y9dG/build/fs/xfs/scrub/agheader.c:96:24: error: implicit declaration of function 'XFS_AGFL_SIZE'; did you mean 'XFS_ACL_SIZE'? [-Werror=implicit-function-declaration] for (i = flfirst; i < XFS_AGFL_SIZE(mp); i++) { ^~~~~~~~~~~~~ XFS_ACL_SIZE The backport didn't replace all the occurrences of the XFS_AGFL_SIZE by the xfs_agfl_size function. Fix: A SAUCE patch is needed to fix the backport, given that the problem doesn't exist with mainline. Testcase: Enable CONFIG_XFS_ONLINE_SCRUB and compile the kernel. Note: bionic/linux doesn't have this config option enabled. The only 4.15 kernel with this config is bionic/linux-gcp, so it affects only this kernel and its backport. ** Affects: linux (Ubuntu) Importance: Undecided Status: Fix Released ** Affects: linux-gcp (Ubuntu) Importance: Undecided Status: Fix Released ** Affects: linux (Ubuntu Bionic) Importance: Undecided Status: In Progress ** Affects: linux-gcp (Ubuntu Bionic) Importance: Undecided Status: In Progress ** Also affects: linux (Ubuntu Bionic) Importance: Undecided Status: New ** Changed in: linux (Ubuntu Bionic) Status: New => Confirmed ** Changed in: linux (Ubuntu) Status: New => Invalid ** Changed in: linux (Ubuntu) Status: Invalid => Fix Released ** Also affects: linux-gcp (Ubuntu) Importance: Undecided Status: New ** Changed in: linux (Ubuntu Bionic) Status: Confirmed => In Progress ** Changed in: linux-gcp (Ubuntu Bionic) Status: New => In Progress ** Changed in: linux-gcp (Ubuntu) Status: New => Fix Released -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1792393 Title: Kernel 4.15.0-35.38 fails to build with CONFIG_XFS_ONLINE_SCRUB enabled Status in linux package in Ubuntu: Fix Released Status in linux-gcp package in Ubuntu: Fix Released Status in linux source package in Bionic: In Progress Status in linux-gcp source package in Bionic: In Progress Bug description: SRU Justification: Impact: The backport of a78ee256c325 ("xfs: convert XFS_AGFL_SIZE to a helper function") done as part of "Bionic update: upstream stable patchset 2018-08-24" (bug 1788897) is incomplete, causing the build to fail if CONFIG_XFS_ONLINE_SCRUB is selected. /tmp/kernel-kleber-79aa9f7-Y9dG/build/fs/xfs/scrub/agheader.c: In function 'xfs_scrub_walk_agfl': /tmp/kernel-kleber-79aa9f7-Y9dG/build/fs/xfs/scrub/agheader.c:96:24: error: implicit declaration of function 'XFS_AGFL_SIZE'; did you mean 'XFS_ACL_SIZE'? [-Werror=implicit-function-declaration] for (i = flfirst; i < XFS_AGFL_SIZE(mp); i++) { ^~~~~~~~~~~~~ XFS_ACL_SIZE The backport didn't replace all the occurrences of the XFS_AGFL_SIZE by the xfs_agfl_size function. Fix: A SAUCE patch is needed to fix the backport, given that the problem doesn't exist with mainline. Testcase: Enable CONFIG_XFS_ONLINE_SCRUB and compile the kernel. Note: bionic/linux doesn't have this config option enabled. The only 4.15 kernel with this config is bionic/linux-gcp, so it affects only this kernel and its backport. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1792393/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp