There was the following response from the original patch author:
On Fri, Aug 10, 2018 at 12:13:53PM -0400, Joseph Salisbury wrote:
> Hi Daniel,
>
> A kernel bug report was opened against Ubuntu [0]. It was found the
> following patch introduced the regression:
>
> da9970668948 ("usb: xhci: Add XHCI_TRUST_TX_LENGTH for Renesas uPD720201")
I can see nothing in http://pad.lv/1773704 that indicates a regression
in this patch. How could there be? The patch does not not alter the
behaviour of uPD720202 devices (pdev->device == 0x0015).
> The bug reporter claims there is a typo in the patch that caused the
> regression. I built a test kernel with a change to the suspected typo
> and the bug reporter claims it resolved the regression. My test kernel
> had the following change:
>
> - pdev->device == 0x0014)
> + pdev->device == 0x0015)
>
> I was hoping to get your feedback, since you are the patch author. Do
> you think this is an actual typo, or maybe there really needs to be two
> quirks?
No, it is a not a typo (and the change above *does* introduce a regression
). From this git logs I believe that:
0x0014 -> uPD720201
0x0015 -> uPD720202
Daniel.
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1773704
Title:
Typo at line 184 in xhci-pci.c makes trouble for Renesas USB chipset
in Bionic 18.04
Status in linux package in Ubuntu:
In Progress
Status in linux source package in Bionic:
In Progress
Bug description:
A typo at line 184 in /drivers/usb/host/xhci-pci.c trashes a good fix.
183 if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
184 pdev->device == 0x0014)
185 xhci->quirks |= XHCI_TRUST_TX_LENGTH;
186 if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
187 pdev->device == 0x0015)
188 xhci->quirks |= XHCI_RESET_ON_RESUME;
Line 184 should be identical to line 187, ie: should read pdev->device
== 0x0015)
I've compiled the kernel both with and without the typo. As written,
hundreds of messages fill dmesg suggesting XHCI_TRUST_TX_LENGTH may be
needed when zoneminder tries to access my USB webcams. With the fix
applied as I've suggested the messages disappear.
The typo is still present in 4.15.0-22.24
For more background, you may refer to bug ID #1710548
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773704/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
