** Description changed:

  Impact:
  
  The snapcraft.yaml in bionic/master invokes the now obsolete
  'firmware_install' target that was removed in
  5620a0d1aacd554ebebcff373e31107bb1ef7769 ("firmware: delete in-kernel
- firmware"), and by invoking a non existing target, it fails to build.
+ firmware"), and by invoking a non existing target, it breaks the build
+ process.
  
  On a generic amd64 environment, check out the Bionic/generic tree, cd
  into it and execute snapcraft:
  
  linux $ snapcraft
  ...
  make -j4 bzImage modules
  ...
    LD [M]  virt/lib/irqbypass.ko
  make: *** No rule to make target 'firmware_install'.  Stop.
  make: *** Waiting for unfinished jobs....
    INSTALL arch/x86/crypto/blowfish-x86_64.ko
  ...
  make -j4 CONFIG_PREFIX=/home/flag/canonical/linux/parts/kernel/install 
modules_install 
INSTALL_MOD_PATH=/home/flag/canonical/linux/parts/kernel/install 
firmware_install 
INSTALL_FW_PATH=/home/flag/canonical/linux/parts/kernel/install/lib/firmware
  Failed to run 'make -j4 
CONFIG_PREFIX=/home/flag/canonical/linux/parts/kernel/install modules_install 
INSTALL_MOD_PATH=/home/flag/canonical/linux/parts/kernel/install 
firmware_install 
INSTALL_FW_PATH=/home/flag/canonical/linux/parts/kernel/install/lib/firmware' 
for 'kernel': Exited with code 2.
  Verify that the part is using the correct parameters and try again.
  
  Fix:
  
  Since firmware files were removed from the Linux source code, and we
  rely on files provided by the linux-firmware package, skip invoking
  'firmware_install' altogether and fix the build.
  
  linux $ snapcraft
  ...
- Staging kernel 
- Staging firmware 
- Priming kernel 
- Priming firmware 
+ Staging kernel
+ Staging firmware
+ Priming kernel
+ Priming firmware
  Determining the version from the project repo (version-script).
  The version has been set to '4.15.0-24.26'
- Snapping 'pc-kernel' |                                                        
                                                           
+ Snapping 'pc-kernel' |
  Snapped pc-kernel_4.15.0-24.26_amd64.snap
  linux $
  
  Regression risk:
  
  None since the patch only modifies the snapcraft.yaml file.

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1782166

Title:
  Invoking obsolete 'firmware_install' target breaks snap build

Status in linux package in Ubuntu:
  Incomplete

Bug description:
  Impact:

  The snapcraft.yaml in bionic/master invokes the now obsolete
  'firmware_install' target that was removed in
  5620a0d1aacd554ebebcff373e31107bb1ef7769 ("firmware: delete in-kernel
  firmware"), and by invoking a non existing target, it breaks the build
  process.

  On a generic amd64 environment, check out the Bionic/generic tree, cd
  into it and execute snapcraft:

  linux $ snapcraft
  ...
  make -j4 bzImage modules
  ...
    LD [M]  virt/lib/irqbypass.ko
  make: *** No rule to make target 'firmware_install'.  Stop.
  make: *** Waiting for unfinished jobs....
    INSTALL arch/x86/crypto/blowfish-x86_64.ko
  ...
  make -j4 CONFIG_PREFIX=/home/flag/canonical/linux/parts/kernel/install 
modules_install 
INSTALL_MOD_PATH=/home/flag/canonical/linux/parts/kernel/install 
firmware_install 
INSTALL_FW_PATH=/home/flag/canonical/linux/parts/kernel/install/lib/firmware
  Failed to run 'make -j4 
CONFIG_PREFIX=/home/flag/canonical/linux/parts/kernel/install modules_install 
INSTALL_MOD_PATH=/home/flag/canonical/linux/parts/kernel/install 
firmware_install 
INSTALL_FW_PATH=/home/flag/canonical/linux/parts/kernel/install/lib/firmware' 
for 'kernel': Exited with code 2.
  Verify that the part is using the correct parameters and try again.

  Fix:

  Since firmware files were removed from the Linux source code, and we
  rely on files provided by the linux-firmware package, skip invoking
  'firmware_install' altogether and fix the build.

  linux $ snapcraft
  ...
  Staging kernel
  Staging firmware
  Priming kernel
  Priming firmware
  Determining the version from the project repo (version-script).
  The version has been set to '4.15.0-24.26'
  Snapping 'pc-kernel' |
  Snapped pc-kernel_4.15.0-24.26_amd64.snap
  linux $

  Regression risk:

  None since the patch only modifies the snapcraft.yaml file.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1782166/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to     : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to