From: Joseph Salisbury <joseph.salisb...@canonical.com> Date: Mon, 11 Dec 2017 15:35:34 -0500
> A kernel bug report was opened against Ubuntu [0]. It was found that > reverting the following commit resolved this bug: > > commit b2504a5dbef3305ef41988ad270b0e8ec289331c > Author: Eric Dumazet <eduma...@google.com> > Date: Tue Jan 31 10:20:32 2017 -0800 > > net: reduce skb_warn_bad_offload() noise > > > The regression was introduced as of v4.11-rc1 and still exists in > current mainline. > > I was hoping to get your feedback, since you are the patch author. Do > you think gathering any additional data will help diagnose this issue, > or would it be best to submit a revert request? > > This commit did in fact resolve another bug[1], but in the process > introduced this regression. It helps if you can consolidate the information obtained in your bug tracking here in the email so that people on this list can get an idea of what the problem scope might be without having to go to your special bug tracking site. This is really not about us being snobs about this mailing list, it's about you wanting to get a result. And you'll get a better result faster if you post the details here on the lsit because most developers are not going to go to your bug tracking site to read the bug comments. Also, this isn't a functional regression, it is just that we are generating warnings that we didn't before. It doesn't mean that Eric's patch is wrong, it could just be that his new check is triggering for a bug that has always been there. Scanning the bug myself it seems that the critical required component is IPSEC, and IPSEC has it's own way of doing segmentation offload. Thanks. -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1715609 Title: kernel warning: skb_warn_bad_offload Status in linux package in Ubuntu: In Progress Status in linux source package in Xenial: In Progress Status in linux source package in Zesty: In Progress Bug description: Since upgrading to kernel version 4.10.0-33.37, we're seeing a lot of call traces triggered by skb_warn_bad_offload in the syslog. Regression introduced when fixing this bug? https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1705447 kernel: [570943.494444] ------------[ cut here ]------------ kernel: [570943.494448] WARNING: CPU: 3 PID: 21982 at /build/linux-hwe-YA6IuF/linux-hwe-4.10.0/net/core/dev.c:2576 skb_warn_bad_offload+0xd1/0x120 kernel: [570943.494450] e1000e: caps=(0x00000030002149a9, 0x0000000000000000) len=1701 data_len=1659 gso_size=1480 gso_type=2 ip_summed=0 kernel: [570943.494451] Modules linked in: udp_diag tcp_diag inet_diag echainiv authenc xfrm4_mode_tunnel xt_state binfmt_misc veth xfrm_user xfrm4_tunnel tunnel4 ipcomp xfrm_ipcomp esp4 ah4 af_key xfrm_algo bridge stp llc iptable_mangle ipt_MASQUERADE nf_nat_masquerade_ipv4 iptable_nat nf_nat_ipv4 nf_nat ipt_REJECT nf_reject_ipv4 xt_tcpudp nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack iptable_filter ip_tables x_tables intel_rapl x86_pkg_temp_thermal intel_powerclamp coretemp kvm_intel kvm ppdev irqbypass crct10dif_pclmul crc32_pclmul ghash_clmulni_intel pcbc aesni_intel aes_x86_64 crypto_simd glue_helper cryptd intel_cstate intel_rapl_perf hci_uart ie31200_edac btbcm edac_core intel_pch_thermal btqca serio_raw btintel bluetooth parport_pc parport mac_hid intel_lpss_acpi acpi_pad intel_lpss autofs4 kernel: [570943.494500] btrfs raid10 raid456 async_raid6_recov async_memcpy async_pq async_xor async_tx xor raid6_pq libcrc32c raid0 multipath linear raid1 e1000e psmouse ptp ahci pps_core libahci wmi pinctrl_sunrisepoint i2c_hid video pinctrl_intel hid fjes kernel: [570943.494524] CPU: 3 PID: 21982 Comm: charon Tainted: G W 4.10.0-33-generic #37~16.04.1-Ubuntu kernel: [570943.494524] Hardware name: ... kernel: [570943.494525] Call Trace: kernel: [570943.494541] <IRQ> kernel: [570943.494544] dump_stack+0x63/0x90 kernel: [570943.494545] __warn+0xcb/0xf0 kernel: [570943.494546] warn_slowpath_fmt+0x5f/0x80 kernel: [570943.494547] ? ___ratelimit+0xa2/0xf0 kernel: [570943.494549] skb_warn_bad_offload+0xd1/0x120 kernel: [570943.494550] __skb_gso_segment+0x17d/0x190 kernel: [570943.494564] validate_xmit_skb+0x14f/0x2a0 kernel: [570943.494565] validate_xmit_skb_list+0x43/0x70 kernel: [570943.494567] sch_direct_xmit+0x16b/0x1c0 kernel: [570943.494568] __dev_queue_xmit+0x47e/0x690 kernel: [570943.494569] dev_queue_xmit+0x10/0x20 kernel: [570943.494570] ip_finish_output2+0x27a/0x370 kernel: [570943.494571] ip_finish_output+0x176/0x270 kernel: [570943.494571] ip_output+0x76/0xe0 kernel: [570943.494572] ? ip_fragment.constprop.49+0x80/0x80 kernel: [570943.494573] ip_forward_finish+0x43/0x70 kernel: [570943.494574] ip_forward+0x385/0x460 kernel: [570943.494575] ? ip_frag_mem+0x50/0x50 kernel: [570943.494575] ip_rcv_finish+0x11b/0x400 kernel: [570943.494576] ip_rcv+0x28b/0x3a0 ... kernel: [570943.494632] ---[ end trace f01d0adcc1256afe ]--- To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1715609/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
