Another data point for consideration... (I didn't think of this until late last night)
git checkout Ubuntu-3.10.0-0.6 git revert 313a58e487ab3eb80e7e1f9baddc75968288aad9 # resolve a header conflict - nothing major After building this, I was able to use the network dongle just fine (ie. second and third pegasus-related commits were ok, one of them even removed that warning when inserting the device). I had a look at the commit and it looks ok... I'm guessing from the change in code that the "pool" was not necessary, and that the extra skb buffer objects went unused most of the time. However, I believe they hid a buffer overrun. The skb buffer was previously allocated as PEGASUS_MTU + 2. The new buffer is allocated as PEGASUS_MTU (with optional padding for alignment purposes). From what I can see, this should make the usable buffer consistently smaller than the old structure allowed for (by 2 bytes). The real problem though, is that when reading into the skb buffer, the driver uses PEGASUS_MTU + 8 as the buffer size, a pretty clear buffer overrun to me. I don't know how the kernel is allocating this memory but I guess the underlying allocation pattern of the "pool" code was able to hide the effect of the overrun and this change merely exposed it by changing the allocation pattern. Indeed, the attached patch (which passes the correct buffer size to the read function) also fixes things. I suppose this is the fix that should be committed. I guess this needs to go upstream to the kernel guys though? ** Patch added: "0001-pegasus-Do-not-write-more-data-to-the-buffer-than-it.patch" https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1547838/+attachment/4620180/+files/0001-pegasus-Do-not-write-more-data-to-the-buffer-than-it.patch -- You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu. https://bugs.launchpad.net/bugs/1547838 Title: ADMtek ADM8511 "Pegasus II" USB Ethernet causes oops Status in linux package in Ubuntu: Confirmed Bug description: This is a rather old USB ethernet adapter. It worked fine for me with older distributions (including Ubuntu 10.04). I noticed it causing problems after upgrading to 14.04 and stopped using it as a result (since I needed reliable USB ethernet for work). I was also not completely sure if it was this device causing the issue or interplay between this device and a number of other networking USB devices that were used at work. I'd like to use this ethernet adapter at home but the machine is running Ubuntu 14.04 and the issue persists. I have collected some information that might help. I'm happy to try more things to collect information if that will help. I'm running Ubuntu 14.04 server 64-bit. I just rebooted so I'm running the latest updates. I was told to run ubuntu-bug linux but I'm not sure how much useful stuff is included in that. I'm including the kernel log which has some bad stuff happening in it. Not sure if it got the system-freezing oops or just the errors leading up to that. It feels like a bug in the driver that corrupts memory because I see issues with network-related things (eg. a ping crashed, but the next ping didn't), leading to a full-system freeze. This machine has been happily running Ubuntu for a looong time (though it was only recently upgraded to Ubuntu 14.04, previously it had been running 10.04). I have not had stability issues with the machine but plugging in the USB Ethernet reliably makes it freeze within minutes. The symptoms also match what I saw on my machine at work. ProblemType: Bug DistroRelease: Ubuntu 14.04 Package: linux-image-3.19.0-49-generic 3.19.0-49.55~14.04.1 ProcVersionSignature: Ubuntu 3.19.0-49.55~14.04.1-generic 3.19.8-ckt12 Uname: Linux 3.19.0-49-generic x86_64 ApportVersion: 2.14.1-0ubuntu3.19 Architecture: amd64 Date: Sat Feb 20 21:23:29 2016 InstallationDate: Installed on 2015-12-31 (50 days ago) InstallationMedia: Ubuntu-Server 14.04.3 LTS "Trusty Tahr" - Beta amd64 (20150805) SourcePackage: linux-lts-vivid UpgradeStatus: No upgrade log present (probably fresh install) --- AlsaVersion: Advanced Linux Sound Architecture Driver Version k3.19.0-49-generic. AplayDevices: Error: [Errno 2] No such file or directory ApportVersion: 2.14.1-0ubuntu3.19 Architecture: amd64 ArecordDevices: Error: [Errno 2] No such file or directory AudioDevicesInUse: Error: command ['fuser', '-v', '/dev/snd/by-path', '/dev/snd/hwC0D1', '/dev/snd/hwC0D0', '/dev/snd/pcmC0D2c', '/dev/snd/pcmC0D2p', '/dev/snd/pcmC0D1p', '/dev/snd/pcmC0D0c', '/dev/snd/pcmC0D0p', '/dev/snd/controlC0', '/dev/snd/seq', '/dev/snd/timer'] failed with exit code 1: CRDA: Error: [Errno 2] No such file or directory Card0.Amixer.info: Error: [Errno 2] No such file or directory Card0.Amixer.values: Error: [Errno 2] No such file or directory DistroRelease: Ubuntu 14.04 HibernationDevice: RESUME=UUID=0cffa533-89ec-44d8-b5f9-6efe69c1b955 InstallationDate: Installed on 2015-12-31 (67 days ago) InstallationMedia: Ubuntu-Server 14.04.3 LTS "Trusty Tahr" - Beta amd64 (20150805) MachineType: Hewlett-Packard HP EliteBook 8530w Package: linux (not installed) ProcFB: 0 nouveaufb ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-3.19.0-49-generic root=UUID=d4c67c71-679c-4b9d-8e20-848149e8aedf ro debug ignore_loglevel crashkernel=384M-:128M ProcVersionSignature: Ubuntu 3.19.0-49.55~14.04.1-generic 3.19.8-ckt12 RelatedPackageVersions: linux-restricted-modules-3.19.0-49-generic N/A linux-backports-modules-3.19.0-49-generic N/A linux-firmware 1.127.20 RfKill: Error: [Errno 2] No such file or directory Tags: trusty Uname: Linux 3.19.0-49-generic x86_64 UpgradeStatus: No upgrade log present (probably fresh install) UserGroups: WifiSyslog: _MarkForUpload: True dmi.bios.date: 06/08/2010 dmi.bios.vendor: Hewlett-Packard dmi.bios.version: 68PDV Ver. F.12 dmi.board.name: 30E7 dmi.board.vendor: Hewlett-Packard dmi.board.version: KBC Version 90.27 dmi.chassis.type: 10 dmi.chassis.vendor: Hewlett-Packard dmi.modalias: dmi:bvnHewlett-Packard:bvr68PDVVer.F.12:bd06/08/2010:svnHewlett-Packard:pnHPEliteBook8530w:pvrF.12:rvnHewlett-Packard:rn30E7:rvrKBCVersion90.27:cvnHewlett-Packard:ct10:cvr: dmi.product.name: HP EliteBook 8530w dmi.product.version: F.12 dmi.sys.vendor: Hewlett-Packard To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1547838/+subscriptions -- Mailing list: https://launchpad.net/~kernel-packages Post to : kernel-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~kernel-packages More help : https://help.launchpad.net/ListHelp
