https://bugs.kde.org/show_bug.cgi?id=227942
--- Comment #3 from Thomas McGuire <mcguire kde org> 2010-02-28 23:50:14 --- Hi "[email protected]", your patch looks fine, thanks! Your patch is against KMail 1, which is in a total feature freeze. New features like in this patch can't be added to KMail 1. All new features should only be added to KMail 2, which is being developed in trunk. Can you change your patch so that it is based on trunk? That would be good, since that's the only way your patch can make it into KDE. There are some changes in KMail 2, for example KMMsgInfo and the binary index for it no longer exist, so the patch needs some adjustments. Please use reviewboard.kde.org the next time, see a more detailed description on http://techbase.kde.org/Contribute/Send_Patches. Patches attached to bug reports tend to get lost :) On a side note: Older KMail version implemented sorting by the order of arrival by simply using the serial number (which is the Akonadi Item Id now) as sort criteria. Also, older versions didn't have an additional column for sorting by order of arrival, instead you could sort by that just by clicking on the date header in the message list several times. I don't know which is the better way from a usability POV, your solution is also fine. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ Kdepim-bugs mailing list [email protected] https://mail.kde.org/mailman/listinfo/kdepim-bugs
