https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280469
--- Comment #5 from Jason E. Hale <[email protected]> --- Thanks for the updated patch! I'm double-checking it now. There aren't many OPTIONS_SUBs to deal with in this port, so I'm not sure why `make makeplist` wouldn't work as a pretty decent baseline. Maybe "%%DATADIR%%/externaltools/lrelease.xml" will erroneously be replaced with "%%DATADIR%%/externaltools/l%%CMAKE_BUILD_TYPE%%.xml", but that's an easy counter-sed. This CMAKE_BUILD_TYPE sub from Uses/cmake.mk should probably be limited to *.cmake and *.json files, but that's another battle. Thankfully, there only a handful of ports with questionable subs stemming from this, where defining WITH_DEBUG might break them. Png/svg files, for example, seem really suspect for needing debug/release branding. Even some of our own on kde@ (x11-themes/kf[56]-breeze-icons, for example) need fixing on that account. Adding those to my TODO list. Anyways, I'll just take this opportunity to plug tcberner's poudlist tool [1] since it isn't a port yet and is probably not widely known. Basically, it takes a poudriere log with plist issues and automatically adjusts the pkg-plist. Just another option to potentially make things easier in the future instead of manually editing the pkg-plist. It still has a few bugs, but overall has saved me a lot of time updating the Qt and CMake ports. [1] https://codeberg.org/tcberner/poudlist -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.
