ervin added inline comments.
INLINE COMMENTS
> kconfig_compiler.cpp:1024
> +
> + auto valueMap = std::map<QString, QString> {
> + {QStringLiteral("string"), QStringLiteral("const QString &")},
std::map looks like a bad idea here, either use QHash (preferred in massively
based Qt code) or std::unordered_map.
Also for both temporaries you pay the price of their allocation and
deallocation at each call. Even a mutex used at each call would do better. ;-)
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D26126
To: tcanabrava
Cc: ervin, GB_2, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
