meven created this revision. meven added reviewers: crossi, mart, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision.
REVISION SUMMARY ConfigModule are instantiated before KCModuleQml in KCModuleLoader. ConfigModule can sometimes change their representsDefault before KCModuleQml is instantiated. Furthermore KCModuleProxyPrivate::loadModule that wires the connection between defaulted signal and the restore button state update is set up after KCModuleQml constructor. This causes KCModuleQml whose ConfigModule setup their representsDefaults before they are loaded, to have their restore default alwaas enabled regardless of their ConfigModule representsDefaults value. TEST PLAN NightColor KCM with D26049 <https://phabricator.kde.org/D26049> After: On load with default settings saved, the "restore default" button is disabled. Before: On load "restore default" button is always enabled. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D26085 AFFECTED FILES src/kcmoduleqml.cpp To: meven, crossi, mart, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
