ervin added a comment.
In D24490#543810 <https://phabricator.kde.org/D24490#543810>, @kossebau wrote: > In D24490#543807 <https://phabricator.kde.org/D24490#543807>, @ervin wrote: > > > In D24490#543724 <https://phabricator.kde.org/D24490#543724>, @kossebau wrote: > > > > > How does this effect the BIC of the generated classes? Consumers might have exposed the generated classes in public API. Any chance this could become a opt-in change for KF5 times? > > > > > > To my knowledge it shouldn't, it's like adding an extra constructor really. > > > On the source-compatibility layer I would agree it is, but what about the API symbol layer (which is what I meant with public API, as in, exported visible symbols). Right, the type info will change the symbol indeed. Other option is to add an extra ctor instead. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24490 To: ervin, #plasma, #frameworks, dfaure, mart, apol Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
