hallas added a comment.
In D23214#513408 <https://phabricator.kde.org/D23214#513408>, @meven wrote: > In D23214#513396 <https://phabricator.kde.org/D23214#513396>, @hallas wrote: > > > Hey @meven I have been working on the same thing D21760 <https://phabricator.kde.org/D21760> - maybe we should consolidate our efforts? The code you have written looks very similar to what I have been doing :) As you can read in the review comments for D21760 <https://phabricator.kde.org/D21760> the current suggestion is to look into doing a KJob subclass. > > > Great suggestion I missed this prior diff. > > Abandoned in favor of D21760 <https://phabricator.kde.org/D21760> and adding a KJob for this use case I am currently working on re-working the code to derive from KJob, will post an updated patch soon :) Also, please take a look at the code and come with review comments/suggestions :) REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23214 To: meven, davidedmundson, #frameworks Cc: hallas, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
