meven commandeered this revision. meven added a reviewer: ngraham. meven added inline comments.
INLINE COMMENTS > pino wrote in renamefiledialog.cpp:50-51 > why a minimum size is enforced? For files whose name is short, I think the dialog would not look nice. This look fine in dolphin. Was added in 507984415a2953000ef1edb77c9dbc3364846b13 <https://phabricator.kde.org/R318:507984415a2953000ef1edb77c9dbc3364846b13> > pino wrote in renamefiledialog.cpp:54 > assert in a library, especially when checking user input, is never a good > idea... What would be better ? An ASSERT, removing it altogether ? Printing the message to std-err ? > bruns wrote in renamefiledialog.cpp:60 > space around `|` I really wish we would enforce use of a code formater, community wise ... This is something I miss from rust: `cargo fmt` Such as astyle. > bruns wrote in renamefiledialog.cpp:101 > is this correct for e.g. `foo.jpeg`? - the preferred extension is `jpg`, so > this may select to many characters I have tested it, it works fine with .jpeg files. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17595 To: meven, #frameworks, #dolphin, broulik, ngraham Cc: ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham
