ngraham added inline comments. INLINE COMMENTS
> apol wrote in kfilewidget.cpp:745 > Isn't it a bit weird to do this in setMimeFilter? I did it in `setMimeFilter` since that's where it's determined whether or not there's a limited assortment of mimetypes, which is what controls what the string should be. Conditionalizing it based on mode seemed safe enough considering that there's mode-specific code a few lines above, on 741. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20964 To: ngraham, #vdg, elvisangelaccio, GB_2 Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns