nibags created this revision. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision.
REVISION SUMMARY Changes: - Add missing keyword: `byte-order-mark` (there is only "byte-order-marker" and "bom"). Obtained from: https://docs.kde.org/stable5/en/applications/katepart/config-variables.html - Remove keywords delimiters "*" and "+", because in the "RemoveSpacesOptions" list, the keywords "*" and "+" are not highlighted. - Fix ";" in the "RemoveSpaces" context ("remove-trailing-spaces" variable). The character ";" it is not highlighted as in the rest of the variables, since when writing a value, the context ends. - For a strange reason, the use of `<IncludeRules context="##Modelines"/>`, in others files, causes the line continuation character ("\") to be highlighted as `dsNormal`. This is solved by removing the LineContinue rule in the "Normal" context in Modelines. I consider the LineContinue & DetectSpaces rules to be unnecessary in the "Normal" context, so I've eliminated them. REPOSITORY R216 Syntax Highlighting BRANCH fix-modelines REVISION DETAIL https://phabricator.kde.org/D14274 AFFECTED FILES autotests/reference/highlight.css.ref autotests/reference/review128925-1.css.ref autotests/reference/review128925-2.css.ref data/syntax/modelines.xml To: nibags Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
