thiago added a comment.
Looks good. INLINE COMMENTS > fdsender.cpp:24 > > FdSender::FdSender(const std::string &path) > : m_socketDes(-1) The problem here is the API. Why is it using std::string in the first place? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10273 To: chinmoyr, #frameworks Cc: ossi, thiago, dfaure, michaelh, ngraham