leinir marked 4 inline comments as done. leinir added inline comments. INLINE COMMENTS
> dfaure wrote in httpworker.cpp:41 > 0.1% of the partition size is a rather arbitrary value, no? It could go from > something very tiny to something really big... > > On my 470GB partition this would lead to a 470MB cache for knewstuff, that's > maybe a bit much, given the average size for knewstuff stuff? Maybe a qMin() > call with a maximum value would be useful? Good point yes, it's supposed to be helpful, not take over the system. I'll set a max of 50 megs, should be fine for most uses. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D5638 To: leinir, whiting, apol, dfaure Cc: dfaure, #frameworks
