----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129638/ -----------------------------------------------------------
Review request for KDE Frameworks. Repository: kio Description ------- I need it in webenginepart to handle authenticationRequired(), since webengine doesn't use kioslaves. This includes finishing to document all parameters to the methods. Diffs ----- src/core/kpasswdserverclient.cpp ad7ed32925df22079029ea2b94fb2d191e62a35a src/core/kpasswdserverclient_p.h 37c924a653b87f52e3f6e9059b4846703f5c000c src/core/slavebase.cpp 44ecae555bb5bf787a18e295941c6bace549db26 Diff: https://git.reviewboard.kde.org/r/129638/diff/ Testing ------- kpasswdserver is unittested, this is just the client-side API (wrapping dbus calls). I'll start using it in webenginepart now. Thanks, David Faure