----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129122/#review100127 -----------------------------------------------------------
doesn't look fundamentally wrong ^^ src/kpty.cpp (line 78) <https://git.reviewboard.kde.org/r/129122/#comment67254> no space after the ! or just use ifndef - Oswald Buddenhagen On Oct. 13, 2016, 2:08 p.m., Tobias Berner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129122/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2016, 2:08 p.m.) > > > Review request for KDE Frameworks, Adriaan de Groot, Gleb Popov, Oswald > Buddenhagen, and Martin Tobias Holmedahl Sandsmark. > > > Repository: kpty > > > Description > ------- > > FreeBSD does not have `/usr/libexec/*/utempter`. It does however have > `/usr/libexec/ulog-helper` [1]. > > It uses `login` instead of `add` and `logout` instead of `del`. > > > [1] > https://svnweb.freebsd.org/base/head/libexec/ulog-helper/ulog-helper.c?revision=234469&view=markup > > > Diffs > ----- > > cmake/FindUTEMPTER.cmake 9773963 > src/kpty.cpp 7bf31c3 > > Diff: https://git.reviewboard.kde.org/r/129122/diff/ > > > Testing > ------- > > Builds fine. Still need to test if it is actually working. > > > Thanks, > > Tobias Berner > >
