> On Oct. 16, 2016, 4:12 p.m., Tobias Berner wrote:
> > I'm kind of unsure if this is right. Yes, the tests run now, but isn't the
> > issue rather in the way kpty works (or fails to work on FreeBSD)?
>From what i've understood, this boils down to
>`KPtyDevicePrivate::_k_canRead()` method in kptydevice.cpp. The line 284
if (!::ioctl(q->masterFd(), PTY_BYTES_AVAILABLE, (char *) &available))
returns 0 in `available` and this makes method return `false`. This, in turn,
make `waitFor*` methods return false too.
Now you mention it, i'm also unsure if this `ioctl` behaves different on Linux.
- Gleb
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129197/#review100039
-----------------------------------------------------------
On Oct. 16, 2016, 2:44 p.m., Gleb Popov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129197/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2016, 2:44 p.m.)
>
>
> Review request for KDE Frameworks, Adriaan de Groot, Tobias Berner, Oswald
> Buddenhagen, and Martin Tobias Holmedahl Sandsmark.
>
>
> Repository: kpty
>
>
> Description
> -------
>
> Apparently, KPtyDevice can't be operated on after KPtyProcess finishes. Tweak
> tests accordingly, so they actually test things while the process is still
> running.
>
>
> Diffs
> -----
>
> autotests/kptyprocesstest.cpp 8b0b5b0
>
> Diff: https://git.reviewboard.kde.org/r/129197/diff/
>
>
> Testing
> -------
>
> make test on FreeBSD
>
>
> Thanks,
>
> Gleb Popov
>
>
