> On Sept. 4, 2016, 4:34 a.m., Christoph Feck wrote: > > Andreas, any idea which icon the action could use? > > Andreas Kainz wrote: > I would use visibility and hint to show/hide the font's that are not > available in the selected font. will the font change to "not selected" grayed > out when you show all characters also the ones that aren't available?
"visibility" and "hint" is the same icon, but one of them crossed-out. If I use both of them, it is confusing, because the tool button itself has a selected state (sunken frame and selected background). So I see two options: 1) use the "hint" icon, and make the button unselected by default. Selecting it, the unavailable characters are then grayed out. 2) use the "visibility" icon, and make the button selected by default. Unselecting it, the unavailable characters are then grayed out. Which would you prefer? The code currently uses the unselected button for the default (do not gray-out unavailable characters) but I can reverse it. Regarding your question, I have difficulties to parse it. Let me try to answer from what I understood: If font-merging is enabled, but none of the installed fonts have glyphs for a specific character, then this character is rendered as an rectangle box. The character cell is not disabled, so you will be able to select the character (e.g. to copy/paste it), even if you have no font with this character. - Christoph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128680/#review98855 ----------------------------------------------------------- On Sept. 1, 2016, 6:45 p.m., Christoph Feck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128680/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2016, 6:45 p.m.) > > > Review request for KDE Frameworks, KDE Usability and Andreas Kainz. > > > Bugs: 97420 > https://bugs.kde.org/show_bug.cgi?id=97420 > > > Repository: kwidgetsaddons > > > Description > ------- > > Adds a toolbutton to the right of the font combobox to control the "font > merging" property of QFont. When selected, characters which are not available > in the font are disabled. > > Seeking feedback about: > - placement of the button > - used icon (currently "format-text-strikethrough"; it shows an S character > which could stand for "substitution") > - action name and tooltip (see line 477 and 479) > - and code changes ;) > > I was unsure if the toolbutton could have a popup menu showing three options: > 1) show characters from all fonts > 2) disable characters not available in font > 3) hide characters not available in font > > but I did not implement it, because it felt odd not being able to see _which_ > characters are not available in the font. > > > Diffs > ----- > > src/kcharselect.cpp 30ddd34 > src/kcharselect_p.h db0259c > > Diff: https://git.reviewboard.kde.org/r/128680/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Character table with font substitution (default) > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/15/7220dddb-ca1b-42a2-966c-791925156baf__snapshot1.png > Character table with dimming substituted characters > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/15/67c02866-b12c-4080-b6a4-22e29006448b__snapshot2.png > > > Thanks, > > Christoph Feck > >
