----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128882/#review99061 -----------------------------------------------------------
Ship it! Ship It! - David Faure On Sept. 10, 2016, 7:15 p.m., Antonio Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128882/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2016, 7:15 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > Launching .desktop files which have Terminal=true currently fails, because > kio adds to the konsole command the obsolete KDE4 command line options, which > are not recognized by the KF5 konsole. > > > Diffs > ----- > > src/core/desktopexecparser.cpp c526da7 > > Diff: https://git.reviewboard.kde.org/r/128882/diff/ > > > Testing > ------- > > .desktop files with Terminal=true can be launched again from the Plasma menu > and with kioclient5 exec. > > > Thanks, > > Antonio Rojas > >
