> On Feb. 20, 2016, 7:46 p.m., David Faure wrote: > > src/filewidgets/kurlnavigator.h, line 425 > > <https://git.reviewboard.kde.org/r/127111/diff/1/?file=444588#file444588line425> > > > > I had to read the whole patch to understand "url is set to the first > > path segment that leads from N to O". > > > > First, N and O don't help readability, I first thought the O was 0... > > maybe just spell out "the new url" and "the old url". > > > > Also, a url is not a path. So this could say something like: > > > > \a url is set to the child directory of the new url which is an > > ancestor of the old url > > > > I would then add "this signal allows file managers to pre-select the > > directory that the user is navigating up from".
That sounds better. Fixed in the coming update. - Gregor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127111/#review92587 ----------------------------------------------------------- On Sept. 6, 2016, 9:59 a.m., Gregor Mi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127111/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2016, 9:59 a.m.) > > > Review request for KDE Frameworks, Emmanuel Pescosta and Frank Reininghaus. > > > Bugs: 335616 > https://bugs.kde.org/show_bug.cgi?id=335616 > > > Repository: kio > > > Description > ------- > > Moved logic from https://git.reviewboard.kde.org/r/123253 to here. > > Provides a signal to implement bug > https://bugs.kde.org/show_bug.cgi?id=335616: "Dolphin: Navigate to parent > folder selects child folder". > > > Diffs > ----- > > src/filewidgets/kurlnavigator.h 4ffe56acf9ef7a80ba27ba3a08327e363f98fb0d > src/filewidgets/kurlnavigator.cpp 3c045c5aaadb429fd22d28b55ad20d31b086ef48 > src/filewidgets/urlutil.h PRE-CREATION > tests/CMakeLists.txt bc94a4aefd77fb9ce9b2a24075415aac7c30e5ca > tests/urlutiltest.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/127111/diff/ > > > Testing > ------- > > > Thanks, > > Gregor Mi > >
