----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120000/#review97581 -----------------------------------------------------------
Except the trailing spaces that are here and there, I didn't see anything to say against the patch. Yet as I never worked on the project, I cannot give the ship it... src/unit.h (line 182) <https://git.reviewboard.kde.org/r/120000/#comment65787> You should remove theses trailing spaces. - Olivier Churlaud On July 18, 2016, 11:55 p.m., Garret Wassermann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120000/ > ----------------------------------------------------------- > > (Updated July 18, 2016, 11:55 p.m.) > > > Review request for KDE Frameworks and John Layt. > > > Repository: kunitconversion > > > Description > ------- > > New Thermal and Electrical Units and Convienience Function for KUnitConversion > > > Diffs > ----- > > README.md fe8cbe8 > src/converter.cpp 921897e > src/electrical_current.cpp PRE-CREATION > src/electrical_current_p.h PRE-CREATION > src/electrical_resistance.cpp PRE-CREATION > src/electrical_resistance_p.h PRE-CREATION > src/energy.cpp be12434 > src/thermal_conductivity.cpp PRE-CREATION > src/thermal_conductivity_p.h PRE-CREATION > src/thermal_flux.cpp PRE-CREATION > src/thermal_flux_p.h PRE-CREATION > src/thermal_generation.cpp PRE-CREATION > src/thermal_generation_p.h PRE-CREATION > src/unit.h 9e17624 > src/value.h c602150 > src/value.cpp 6531f00 > src/voltage.cpp PRE-CREATION > src/voltage_p.h PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/120000/diff/ > > > Testing > ------- > > I added some fundamental (base SI) units as well as some common derived units > in SI and English/Imperial system, mostly for electrical or thermal units. I > also added a simple member function to the Value class, symbolAsString(), to > immediately receive the current unit assigned to the Value object as a > QString. I was running into issues with my code where doing > v.unit()->symbol() wasn't working because I was getting KSharedPointers > instead of the object, and the program would just crash. I just wanted the > string! So I made a function, which helped with testing of the units. > > The new categories work fine under my test program. I was able to convert > thermal units back and forth in my test program, so seems ok. The values also > appear correct from my tests (as long as I didn't mess anything up by hand!). > > First time submitting review, so please let me know if there is something > else I should do better next time, thank you. > > > Thanks, > > Garret Wassermann > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
