----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128397/#review97181 -----------------------------------------------------------
Thanks for looking into this! autotests/kiconengine_unittest.cpp (line 69) <https://git.reviewboard.kde.org/r/128397/#comment65637> What's the problem if name() returns "invalid-icon-name" here? src/kiconengine.cpp (line 119) <https://git.reviewboard.kde.org/r/128397/#comment65636> I'm worried that this might do a (slow?) lookup every time it's called? - David Faure On July 7, 2016, 9:55 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128397/ > ----------------------------------------------------------- > > (Updated July 7, 2016, 9:55 p.m.) > > > Review request for KDE Frameworks and Olivier Goffart. > > > Repository: kiconthemes > > > Description > ------- > > QIcon::hasThemeIcon(name) checks if QIcon::name() == name, so icon engine > must return empty string when icon doesn't exist. > Also implement IsNullHook for Qt 5.7. Comes with autotest. > > > Diffs > ----- > > autotests/CMakeLists.txt 0c7de50 > autotests/kiconengine_unittest.cpp PRE-CREATION > src/kiconengine.h 21a63f5 > src/kiconengine.cpp 3ccc7d1 > > Diff: https://git.reviewboard.kde.org/r/128397/diff/ > > > Testing > ------- > > Issue was reported in https://bugreports.qt.io/browse/QTBUG-54595 > Also similar issue https://bugs.kde.org/show_bug.cgi?id=365031 (there is a > check for hasThemeIcon before using the icon, but it returns true which > results in invalid icon name -> no icon). > > > Thanks, > > David Rosca > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
