----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128113/#review96234 -----------------------------------------------------------
I'm not fully convinced by the fix, because it was crashing in disconnect, which sounds like the pointer was dangling, therefore deleteLater could crash too. In addition I can't reproduce the fix here. Finally, this code was already in kdelibs4, so -something- else must have changed. This is worth a more through investigation. If you can still reproduce the crash after reverting your change, can you run that command in valgrind, so we know exactly what's happening? I recommend this alias: alias memcheck="QT_ENABLE_REGEXP_JIT=0 valgrind --tool=memcheck --partial-loads-ok=yes --read-var-info=yes" - David Faure On June 6, 2016, 7:53 p.m., Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128113/ > ----------------------------------------------------------- > > (Updated June 6, 2016, 7:53 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kjobwidgets > > > Description > ------- > > + Fix memory leak in finished > > > Diffs > ----- > > src/kuiserverjobtracker.cpp ebed3a5 > > Diff: https://git.reviewboard.kde.org/r/128113/diff/ > > > Testing > ------- > > ark --changetofirstpath --add --autofilename zip kjobwidgets > Crash before, fix with patch > > > File Attachments > ---------------- > > backtrace > > https://git.reviewboard.kde.org/media/uploaded/files/2016/06/06/5b87387e-7e7b-4982-b91b-a18f72414509__backtrace > > > Thanks, > > Anthony Fieroni > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
