----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128088/#review96175 -----------------------------------------------------------
> Like $QT_PLUGIN_PATH/kf5/kio or something else? Actually this subfolder seems to be reserved for the kioslave plugins. Maybe something like `$QT_PLUGIN_PATH/kf5/kio_fileitemaction`? This would be consistent with `$QT_PLUGIN_PATH/kf5/kio_dnd` where `KIO::DndPopupMenuPlugin` plugins [are supposed to be installed](https://api.kde.org/frameworks/kio/html/classKIO_1_1DndPopupMenuPlugin.html). - Elvis Angelaccio On June 3, 2016, 2:27 p.m., Elvis Angelaccio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128088/ > ----------------------------------------------------------- > > (Updated June 3, 2016, 2:27 p.m.) > > > Review request for Dolphin and KDE Frameworks. > > > Repository: dolphin > > > Description > ------- > > Dolphin currently doesn't support JSON-only KFileItemAction plugins (without > a .desktop file). > This patch adds support for them both in the context menu and in the settings > dialog (Services pane). > > Since a plugin can have both a .desktop file and JSON metadata (as is the the > case for `kactivitymanagerd_fileitem_linking_plugin`), we need to be sure to > not add twice the plugin in the context menu. A QSet is used to prevent this > issue. > > Open question: do we want to install these json-only plugins in a specific > subdirectory of `$QT_PLUGIN_PATH`? Like `$QT_PLUGIN_PATH/kf5/kio` or > something else? This way we could tell Dolphin to only look for plugins > within that subfolder (instead of checking every plugin in `$QT_PLUGIN_PATH`). > > > Diffs > ----- > > src/dolphincontextmenu.cpp dfec76144dafd9210aa8b6f45458ded98e27ab53 > src/settings/services/servicessettingspage.cpp > 4cfa2327c9fa77a6124b4d90040a9784cc8180c5 > > Diff: https://git.reviewboard.kde.org/r/128088/diff/ > > > Testing > ------- > > * Apply https://phabricator.kde.org/D1761 to Ark master > * Make sure that the Compress and Extract service menus are shown > * Make sure that the menus above can be enabled/disabled in the Services pane > in the settings > * Make sure that `kactivitymanagerd_fileitem_linking_plugin` is not shown > twice in the context menu > > > Thanks, > > Elvis Angelaccio > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
