----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127878/#review95382 -----------------------------------------------------------
src/widgets/kfileitemdelegate.cpp (line 1220) <https://git.reviewboard.kde.org/r/127878/#comment64671> QCommonStyle when rendering CE_ItemViewItem checks for disabled first QIcon::Mode mode = QIcon::Normal; if (!(vopt->state & QStyle::State_Enabled)) mode = QIcon::Disabled; else if (vopt->state & QStyle::State_Selected) mode = QIcon::Selected; qcommonstyle:2167 it's probably best to emulate that also why do you have the && active? That means it'd need to be both selected and have mouse over at the same time in order to change icon? - David Edmundson On May 10, 2016, 11:57 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127878/ > ----------------------------------------------------------- > > (Updated May 10, 2016, 11:57 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kio > > > Description > ------- > > since now kiconloader can color the icons in the sidebar, by using the > "selected" icon mode, when the breeze icon theme is used the icon of the > current sidebar item will be of the same color of selected text (white-ish by > default), is more in line with breeze style and the monochrome icons become > more readable > > > Diffs > ----- > > src/filewidgets/kfileplacesview.cpp 03074e0 > src/widgets/kfileitemdelegate.cpp 1516b9e > > Diff: https://git.reviewboard.kde.org/r/127878/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > menu3.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/41f52d86-6fc5-4799-bd9e-18d17dc5a65a__menu3.png > > > Thanks, > > Marco Martin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
