----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127763/#review94997 -----------------------------------------------------------
Ship it! Ship It! - Albert Astals Cid On April 28, 2016, 12:39 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127763/ > ----------------------------------------------------------- > > (Updated April 28, 2016, 12:39 p.m.) > > > Review request for KDE Frameworks and Christoph Feck. > > > Repository: kiconthemes > > > Description > ------- > > Leverages the implicitly shared nature of QString by only constructing the > paths when it's strictly necessary. It souldn't show a big performance impact > since the generated paths were only intermediate in most cases after all. > > This is especially important now that plasma has several KIconLoader > instances at the same time, but it should have an impact on every application > using kiconthemes (or under the plasma-integration effects). > > > Diffs > ----- > > src/kicontheme.cpp 735ecf7 > > Diff: https://git.reviewboard.kde.org/r/127763/diff/ > > > Testing > ------- > > Tests still pass, apps still work. > > Starting and closing dolphin under callgrind showed 1640M instructions, now > 1466M(10% improvement). > > > File Attachments > ---------------- > > after > > https://git.reviewboard.kde.org/media/uploaded/files/2016/04/28/3f9b64d7-58e0-454b-9774-6ec86aa7f0c3__heaptrack.dolphin.16572-after.gz > before > > https://git.reviewboard.kde.org/media/uploaded/files/2016/04/28/6229961c-bf00-4959-9fc1-9effa63b2b34__heaptrack.dolphin.16861-before.gz > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
