----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127699/#review94839 -----------------------------------------------------------
src/plugins/xscreensaver/xscreensaverbasedpoller.cpp (line 42) <https://git.reviewboard.kde.org/r/127699/#comment64415> Why are you checking for m_screenSaverIface being null? You create it in the ctor and it has the lifespan of XScreensaverBasedPoller. - David Edmundson On April 20, 2016, 4:54 p.m., Paulo Lieuthier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127699/ > ----------------------------------------------------------- > > (Updated April 20, 2016, 4:54 p.m.) > > > Review request for KDE Frameworks and Martin Gräßlin. > > > Repository: kidletime > > > Description > ------- > > If the dbus interface org.freedesktop.ScreenSaver is not present, it makes no > sense to use the plugin. > > > Diffs > ----- > > src/plugins/xscreensaver/xscreensaverbasedpoller.h 05b9a23 > src/plugins/xscreensaver/xscreensaverbasedpoller.cpp f56396c > src/widgetbasedpoller.h 68fc7dc > > Diff: https://git.reviewboard.kde.org/r/127699/diff/ > > > Testing > ------- > > Tested minimal application using KIdleTime using the xscreensaver plugin. > > > Thanks, > > Paulo Lieuthier > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
