----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127004/#review92141 -----------------------------------------------------------
src/widgets/openfilemanagerwindowjob.h (lines 5 - 7) <https://git.reviewboard.kde.org/r/127004/#comment62860> please use the LGPL header as listed on techbase. We use the Lesser GPL, not the older Library GPL. src/widgets/openfilemanagerwindowjob.h (lines 89 - 97) <https://git.reviewboard.kde.org/r/127004/#comment62861> Could you please provide more info about the Startup Id. src/widgets/openfilemanagerwindowjob.h (line 109) <https://git.reviewboard.kde.org/r/127004/#comment62862> also here it would be useful to know what "asn" is - Martin Gräßlin On Feb. 7, 2016, 7:20 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127004/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2016, 7:20 p.m.) > > > Review request for KDE Frameworks, Emmanuel Pescosta and Martin Gräßlin. > > > Repository: kio > > > Description > ------- > > This job uses the org.freedesktop.FileManager1 interface to highlight files > within a certain folder, useful for eg. downloaded files or a "open > containing folder" functionality. > > > Diffs > ----- > > src/widgets/CMakeLists.txt 87dac50 > src/widgets/openfilemanagerwindowjob.h PRE-CREATION > src/widgets/openfilemanagerwindowjob.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/127004/diff/ > > > Testing > ------- > > With Dolphin's org.freedesktop.FileManager1 service installed, I got a file > highlighted properly. Without it Dolphin opened the folder without > highlighting (KRun fallback). > > Not sure what to do with the startup id stuff > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
