> On Дек. 18, 2015, 12:25 п.п., Emmanuel Pescosta wrote: > > src/lib/io/kdirwatch.cpp, line 1067 > > <https://git.reviewboard.kde.org/r/126392/diff/1/?file=424357#file424357line1067> > > > > This is wrong (if I'm not wrong ;) > > > > De Morgan's law [1] says that A or B <=> not ((not A) and (not B)) > > > > Where in this case: > > A, B = list.count > > (not A), (not B) = list.empty > > > > [1] https://en.wikipedia.org/wiki/De_Morgan's_laws
Yes , I realized the error , correct it soon. - Andrey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126392/#review89700 ----------------------------------------------------------- On Дек. 18, 2015, 3:33 д.п., Andrey Cygankov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126392/ > ----------------------------------------------------------- > > (Updated Дек. 18, 2015, 3:33 д.п.) > > > Review request for KDE Frameworks and Aleix Pol Gonzalez. > > > Repository: kcoreaddons > > > Description > ------- > > Fix some Clazy warnings: > - unneeded heap allocation with QString > - midRef() non-usage > - isEmpty() non-usage > > > Diffs > ----- > > autotests/ktexttohtmltest.cpp 81c3fc0 > src/lib/io/kbackup.h ead2de5 > src/lib/io/kbackup.cpp ec8b8b2 > src/lib/io/kdirwatch.cpp 34b32b7 > src/lib/io/kdirwatch_p.h 4483961 > src/lib/io/kmessage.cpp 305318c > src/lib/io/kprocess.cpp 1df61c0 > src/lib/io/kurlmimedata.cpp 4095ee1 > src/lib/kaboutdata.h 0dbd7a0 > src/lib/kaboutdata.cpp 5d9a55e > src/lib/randomness/krandom.cpp 2eb80d2 > src/lib/text/kmacroexpander.cpp 0d05ffd > src/lib/text/kstringhandler.cpp 826ddcb > src/lib/text/ktexttohtml.cpp d58f5c0 > src/lib/util/kshell.cpp 11892ce > > Diff: https://git.reviewboard.kde.org/r/126392/diff/ > > > Testing > ------- > > Compiling without errors > > > Thanks, > > Andrey Cygankov > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
