----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125971/#review88120 -----------------------------------------------------------
Ship it! Looks good. Please do a "make test" before pushing, though. - David Faure On Nov. 7, 2015, 12:35 a.m., Nick Shaforostoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125971/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2015, 12:35 a.m.) > > > Review request for KDE Frameworks, David Faure and Laurent Montel. > > > Repository: karchive > > > Description > ------- > > i couldn't find the place where the pointers contained in the member arrays > are deleted so i have added their releasing. for this i have used qDeleteAll > (you can search for qDeleteAll in the diff) > > also i have reordered members of FileInfo to reduce its 'sizeof' > also using qvector for storing pointers is as fast as using qlist (or even > faster) and needs less memory > also i have switched qvector acces from operator[] to .at() because it is > const (doesn't call detach() method internally) > also i have disabled the code that was filling 'method' string because it was > not used anywhere after > > > Diffs > ----- > > src/k7zip.cpp 321620a > src/karchive.cpp 0ece37c > > Diff: https://git.reviewboard.kde.org/r/125971/diff/ > > > Testing > ------- > > compiles fine > > > Thanks, > > Nick Shaforostoff > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
