----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123514/ -----------------------------------------------------------
(Updated April 29, 2015, 6:28 p.m.) Review request for KDE Frameworks and David Faure. Changes ------- Further polishing. * Increase testing: Create 2 tests, one using QNAM and the other using KIO::AccessManager. This way we can check that the output is the same. * Improve detection of end of stream by using QIODevice::read(char\*, length) instead of ::read(QByteArray). The former returns -1 when the stream ends. * Use QIODevice::readChannelFinished signal instead of QIODevice::aboutToClose. Repository: kio Description ------- So far, we used to just read whenever some data was required. This works on sequential devices because the data is already available. This is not the case when we have a sequential device, such as a socket, where data arrives when it arrives. This will also prove useful on non-sequential devices as well when we want to keep reading in case new data appears. This patch takes the AsyncDataEnabled setting on accordinly by: * only reading from the device when readyRead is available. * finishes the transfer whenever the device is closed. Diffs (updated) ----- src/core/transferjob.h e2fd2e7 src/core/job_p.h 7ec1a69 autotests/jobtest.cpp 327470a autotests/jobtest.h 5ccd492 autotests/accessmanagertest.cpp 5d52553 autotests/CMakeLists.txt 7bba3ea src/core/transferjob.cpp 97a724e src/widgets/accessmanager.cpp b4ec811 Diff: https://git.reviewboard.kde.org/r/123514/diff/ Testing ------- Tests still pass, new test also passes. The test is using lambdas to delay write. I don't think it's available. Can I add some kind of #if HAS_LAMBDA and make the test depend on it? I don't think adding slots and make the buffer an attribute would be very nice... I can also sub-class the buffer. Thanks, Aleix Pol Gonzalez
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
