----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122764/#review76820 -----------------------------------------------------------
I like the idea, but do we make it clear anywhere that COPYING-CMAKE-SCRIPTS applies to only the included CMake scripts, besides the filename? i.e. in a separate README or in the .cmake scripts themselves? If not I would recommend mentioning the files the license pertains to within COPYING-CMAKE-SCRIPTS so that there's no confusion. Other that that I think you're right and I appreciate the effort to develop a fix. - Michael Pyne On Feb. 28, 2015, 7:38 p.m., Maximiliano Curia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122764/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2015, 7:38 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kcoreaddons > > > Description > ------- > > cmake/FindFAM.cmake needs to be distributed with a copy of > COPYING-CMAKE-SCRIPTS > > And a number of files (I count 42 right now) are under the LGPL-2 (without the > or any later version option), and thus it's recommended to distribute the > complete license. > > This patch was done after the rejection of the Debian ftpmasters of > kcoreaddons (https://lists.debian.org/debian-qt-kde/2015/02/msg00239.html). > > > Diffs > ----- > > COPYING-CMAKE-SCRIPTS PRE-CREATION > COPYING.LGPL-2 PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/122764/diff/ > > > Testing > ------- > > > Thanks, > > Maximiliano Curia > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
