> On Feb. 3, 2015, 11:10 p.m., Ivan Čukić wrote: > > This does fix the switching, but I don't agree it is the right place for it > > (I don't like that this plugin exists at all tbh). > > > > When switching the activities, there needs to be a (UI) feedback - the > > switcher needs to show up. That means either moving the switcher UI to this > > plugin (which I don't like), or having this in plasmashell. > > Ivan Čukić wrote: > p.s. And, yes, I know I'm to blame for this being an issue at the moment > instead of having it all in 5.1, but... a lot has happened in the last year :/
Umm, so what about merging this for now here and when you implement/merge the new Activity switcher? I am sure this plugin itself will be removed at that time and hence this shortcuts.. - Bhushan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122408/#review75324 ----------------------------------------------------------- On Feb. 3, 2015, 10:41 p.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122408/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2015, 10:41 p.m.) > > > Review request for KDE Frameworks, Plasma and Ivan Čukić. > > > Bugs: 342186 > http://bugs.kde.org/show_bug.cgi?id=342186 > > > Repository: kactivities > > > Description > ------- > > Currently shellcorona registeres those shortcuts but that is not right place > and it is not working there, so this is place where this should be done > > > Diffs > ----- > > src/service/plugins/globalshortcuts/GlobalShortcutsPlugin.h 54a24a8 > src/service/plugins/globalshortcuts/GlobalShortcutsPlugin.cpp 1a13b6b > > Diff: https://git.reviewboard.kde.org/r/122408/diff/ > > > Testing > ------- > > alt+tab, alt+s works to cycle activities and stop activities but somehow > alt+shift+tab is not working due to some kglobalaccel limitation. > > > Thanks, > > Bhushan Shah > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
