----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122396/ -----------------------------------------------------------
Review request for KDE Frameworks and Martin Klapetek. Repository: knotifications Description ------- knotifyconfig in notify would not be free'd in many case. This patch pass const reference instead of pointer to plugin. And add a copy constructor to KNotifyConfig, so it's not possible to leak anymore. Though API/ABI is changed, knotifyconfig.h is never installed before, which also makes knotificationplugin somewhat useless. And seems there is no knotificationplugin user yet. Diffs ----- src/notifybypopup.h a605a77 src/notifybypopup.cpp 2f08146 src/notifybytaskbar.h 0908787 src/notifybytaskbar.cpp b52e180 src/knotificationmanager.cpp 3cf637c src/knotificationplugin.h 3438e7d src/knotificationplugin.cpp 7315c17 src/knotifyconfig.h fae17cb src/knotifyconfig.cpp af6be92 src/notifybyaudio.h 9a2d531 src/notifybyaudio.cpp d7090ac src/notifybyexecute.h ae362e3 src/notifybyexecute.cpp b5d437a src/notifybyktts.h 43756f7 src/notifybyktts.cpp a2a15a9 src/notifybylogfile.h 6ea2850 src/notifybylogfile.cpp ca3faf9 Diff: https://git.reviewboard.kde.org/r/122396/diff/ Testing ------- Works. Thanks, Xuetian Weng
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
