----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120854/#review69303 -----------------------------------------------------------
Should maybe be "delay < 0"? Either way, +1. - Aleix Pol Gonzalez On Oct. 28, 2014, 4:14 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120854/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2014, 4:14 p.m.) > > > Review request for KDE Frameworks. > > > Bugs: 340238 > https://bugs.kde.org/show_bug.cgi?id=340238 > > > Repository: knotifications > > > Description > ------- > > If delay "-1" is passed, it means "server default", but in KPassivePopup the > default was never set. > > Fixes bug 340238. > > > Diffs > ----- > > src/kpassivepopup.cpp d253898 > > Diff: https://git.reviewboard.kde.org/r/120854/diff/ > > > Testing > ------- > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
