----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118276/#review58429 -----------------------------------------------------------
Ship it! The change seems to make sense and I don't see why anything would break with the change. Also it's one of those "the-sooner-the-better" changes, in case somebody plans to rely on it. - Aleix Pol Gonzalez On May 23, 2014, 2:29 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118276/ > ----------------------------------------------------------- > > (Updated May 23, 2014, 2:29 p.m.) > > > Review request for Kate and KDE Frameworks. > > > Repository: kate > > > Description > ------- > > kwrite has org.kate-editr.kwrite as dbusname in its desktop file, but the > application registers org.kde.kwrite instead (in qt5 org.kate-editor wouldn't > even work because of the dash). this makes klauncher misbehave and KRun() be > blocking freezing the caller until kwrite is closed. > > the patch gives org.kde.kwrite in the desktop file > > possibly related to > https://bugs.kde.org/show_bug.cgi?id=335069 > (even tough kate seems to have the proper name, no probably unrelated) > > Question for frameworks: should KRun() not freeze when such condition is > encountered? > > > Diffs > ----- > > kwrite/CMakeLists.txt 5f461b2 > kwrite/org.kde.kwrite.desktop ba8db4b > > Diff: https://git.reviewboard.kde.org/r/118276/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
