> On May 5, 2014, 6:51 p.m., Alex Merry wrote: > > I don't think we want to do this. The is the framework integration plugin > > for KF5, so putting it in a KF5 directory makes sense (note that there are > > a bunch of other framework plugins that should be put back in a versioned > > subdirectory - I just haven't got round to it yet). Besides, it has to > > match > > http://lxr.kde.org/source/frameworks/kwidgetsaddons/src/kmessagebox_p.cpp?v=kf5-qt5#0089 > > > > OTOH, it should probably use PLUGIN_INSTALL_DIR instead of > > QT_PLUGIN_INSTALL_DIR, since it isn't a plugin for Qt.
ok, i'll adjust it so it uses PLUGIN_INSTALL_DIR and discard r118002 - Hrvoje ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118003/#review57334 ----------------------------------------------------------- On May 5, 2014, 6:14 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118003/ > ----------------------------------------------------------- > > (Updated May 5, 2014, 6:14 p.m.) > > > Review request for KDE Frameworks. > > > Repository: frameworkintegration > > > Description > ------- > > this is now standard location since commit f0607b4 in ecm > > > Diffs > ----- > > src/integrationplugin/CMakeLists.txt 250547f > > Diff: https://git.reviewboard.kde.org/r/118003/diff/ > > > Testing > ------- > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
